Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 63697 - flex-2.5.4a-r5 fails its testsuite
Summary: flex-2.5.4a-r5 fails its testsuite
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-11 12:23 UTC by Robert Moss (RETIRED)
Modified: 2004-11-09 21:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Moss (RETIRED) gentoo-dev 2004-09-11 12:23:19 UTC
>>> Test phase [check]: sys-devel/flex-2.5.4a-r5
./flex -t -p  ./scan.l \
| sed s,\"./scan.l\",\"scan.l\", \
| diff scan.c -
14a15
>
1482c1483
<       register char *yy_cp, *yy_bp;
---
>       register char *yy_cp = NULL, *yy_bp = NULL;
3312a3314
>
make: *** [check] Error 1

!!! ERROR: sys-devel/flex-2.5.4a-r5 failed.
!!! Function src_test, Line 515, Exitcode 0
!!! Make check failed. See above for details.
!!! If you need support, post the topmost build error, NOT this status message.

This has been demonstrated on x86 with both gcc-3.4 and gcc-3.5.

I noted that there are four patches used in the ebuild. Applying them on their own, I get that flex-2.5.4-glibc22.patch gives the error:

./flex -t -p  ./scan.l \
| sed s,\"./scan.l\",\"scan.l\", \
| diff scan.c -
14a15
>
3312a3314
>
make: *** [check] Error 1

flex-2.5.4a-gcc3.patch gives a completed testsuite. The other gcc patch does not apply cleanly to clean sources (it depends on the first gcc patch), but when applied in this fashion, the testsuite also succeeds.

flex-2.5.4a-skel.patch gives:

./flex -t -p  ./scan.l \
| sed s,\"./scan.l\",\"scan.l\", \
| diff scan.c -
1483c1483
<       register char *yy_cp, *yy_bp;
---
>       register char *yy_cp = NULL, *yy_bp = NULL;
make: *** [check] Error 1

This is the original error. However, both patches appear to need fixing, or if this behaviour is now expected, as it would appear from the patch, then the testsuite also needs patching.

**********

NB: There is a better testsuite in there. The make target is "bigcheck", and this passes, as it isn't quite so naive. The solution I would prefer is to use this testsuite by default instead. Fixing the ebuild is obvious so I won't bother with a patch - if someone okays me to fix this I'll commit it.
Comment 1 Robert Moss (RETIRED) gentoo-dev 2004-09-11 12:27:41 UTC
Oh, go on then. Reassigning to base-system. Also...

src_test() {
    make bigcheck || die "make bigcheck failed"
}

Stick that in just before src_install.
Comment 2 Robert Moss (RETIRED) gentoo-dev 2004-09-11 12:29:50 UTC
Oops. Minor error. The glibc patch creates the first half of that error and the skel patch creates the latter half. Silly Rob.
Comment 3 Robert Moss (RETIRED) gentoo-dev 2004-11-09 13:33:21 UTC
Fixed in CVS.
Comment 4 SpanKY gentoo-dev 2004-11-09 21:44:53 UTC
thanks :)