Bug 62365 – kernel-cc/util-cc don't do anything & return values lost leading to false successes

• Status: RESOLVED FIXED
• Product: Gentoo Hosted Projects

[Description Robin Johnson 2004-08-31 02:40:03 UTC]

"genkernel --kernel-cc=/bin/false all"
this works fine, as it totally ignores the specified cc and uses the default of gcc instead.

from gen_compile.sh:
${MAKE} ${MAKEOPTS} ${1} 2>&1 | tee -a ${DEBUGFILE}
RET=$?
$? gives the exit value of tee, NOT make. So after the make fails, genkernel continues!

You need to use ${PIPESTATUS[0]} instead to get the return value of the first item in the pipe. $? is in ${PIPESTATUS[1]}.

I've attached a patch that fixes both of these issues, could you please get it into genkernel ASAP? If you don't have time, I'll commit it myself to the current gentoo/src/genkernel_bradmssw.

[Comment 1 Robin Johnson 2004-08-31 02:40:58 UTC]

Created attachment 38567 [details, diff]
genkernel-3.0.2f-fixes.patch

patch for listed issues.

[Comment 2 Robin Johnson 2004-09-08 19:22:03 UTC]

*bump*

[Comment 3 Tim Yamin (RETIRED) 2004-09-19 02:13:59 UTC]

Thank you for the patch, it's now in CVS. Please accept my apology for this taking so long - if you have any more problems then please reopen this bug or open a new one. Thanks!

[Comment 4 Tim Yamin (RETIRED) 2004-09-19 05:28:27 UTC]

Patch in genkernel-3.0.2g; please reopen this bug if you have any problems. Thanks!