Justification for major: IPv6 users depend on the deep test. /usr/sbin/mirrorselect line 188: wget -t 1 -C off -T 25 -O - ${i}/distfiles/mirrorselect-test 2>/dev/null This results in the file passed to stdout. A console full of garbage isn't quite what I expected. ;o) I need the deep test because of IPv6 connectivity. You either wanted to write ``>/dev/null'' or -o - -O /dev/null. I fixed it by replacing the line with: wget -t 1 -C off -T 25 -o /dev/null -O /dev/null ${i}/distfiles/mirrorselect-test -o /dev/null : Suppreses the log output -O /dev/null : Discards the downloaded data.
I confirm that when doing deep tests with mirrorselect, I get lots of garbage output in stdout.
Created attachment 38386 [details, diff] Proposed patch This is a proposed patch that I hope will fix the problem.
#2 won't fix the problem. All it did was adding a second temporary file which is then used to the data about the mirrors. The problem is wget putting the data to stdout specified by ``-O -''. It would be quite easy to fix and to restore the old behaviour.
Good catch. That "-O -" needs to be changed to "-O ${TMPFILE}", of course.
Created attachment 38403 [details, diff] Revised patch for mirrorselect
0.84 throws a lot of garbage too
should be fixed in 0.86 - regards.
confirmed when will it become stable?
