First Last Prev Next    No search results available      Search page      Enter new bug
Bug#: 59832
Alias:
Product:
Component:
Status: RESOLVED
Resolution: FIXED
Assigned To: Tim Yamin (RETIRED) <plasmaroo@gentoo.org>
Hardware:
OS:
Version:
Priority:
Severity:
Reporter: Cory Visi (RETIRED) <merlin@gentoo.org>
Add CC:
CC:
URL:
Summary:
Status Whiteboard:
Keywords:

Filename Description Type Creator Created Size Actions
sg3_utils-llseek.patch sg3_utils-llseek.patch patch Cory Visi (RETIRED) 2004-08-09 01:02 0000 1.90 KB Details | Diff
sg3_utils-1.06.ebuild.patch sg3_utils-1.06.ebuild.patch patch Cory Visi (RETIRED) 2004-08-09 01:02 0000 756 bytes Details | Diff
Create a New Attachment (proposed patch, testcase, etc.) View All

Bug 59832 depends on: Show dependency tree
Bug 59832 blocks:
Votes: 0    Show votes for this bug    Vote for this bug

Additional Comments: (this is where you put emerge --info)


Not eligible to see or edit group visibility for this bug.






View Bug Activity   |   Format For Printing   |   XML   |   Clone This Bug

Description:   Opened: 2004-08-09 01:01 0000 
sg3_utils uses llseek.c from util-linux. solar fixed util-linux's llseek.c with
files/util-linux-2.11z-pic.patch in July of 2003 (see the ChangeLog).

The _llseek() system call is actually the wrong way to call llseek now, and
while his patch does compile with -fPIC, I believe my implementation is better
(see Bug 51962).

With this change I believe we can compile safely with enhanced CFLAGS.

Finally, I removed the HAS_LONG_LONG check, since there is no configure script
that will ever define this, and the rest of the code uses long long liberally.

Attached is an ebuild and source code patch.

I will submit the source code patch upstream, too.

------- Comment #1 From Cory Visi (RETIRED) 2004-08-09 01:02:17 0000 ------- 
Created an attachment (id=37081) [details]
sg3_utils-llseek.patch

------- Comment #2 From Cory Visi (RETIRED) 2004-08-09 01:02:41 0000 ------- 
Created an attachment (id=37082) [details]
sg3_utils-1.06.ebuild.patch

------- Comment #3 From Tim Yamin (RETIRED) 2004-08-09 14:39:24 0000 ------- 
Now fixed in CVS, it should reach the rsync mirrors shortly - closing as FIXED.
Thanks for the patch and please reopen this bug if you have any further
issues...
First Last Prev Next    No search results available      Search page      Enter new bug