Bug 59326 – FEATURES=maketest default "make check" fails when X connection required. i.e. at-spi-1.4.2

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Daniel Black (RETIRED) 2004-08-03 19:02:05 UTC]

emerging at-spi with FEATURE=maketest results in the portage default src_test routine being executed (make check). Because, in this case, make check expects a X connection (not enabled from root by default) this fails.

I imagine this is similar for a lot of gnome applications. Maybe a src_test in the eclass that calls the default if a X server connection is possible.

Looking thorough my emerge.log this *may* of happened with libgnomecanvas before I turned off the maketest FEATURE.

Output:

>>> Test phase [check]: gnome-extra/at-spi-1.4.2
Making check in docs
make[1]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/docs'
Making check in reference
make[2]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/docs/reference'
Making check in cspi
make[3]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/docs/reference/cspi'
make[3]: Nothing to be done for `check'.
make[3]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/docs/reference/cspi'
make[3]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/docs/reference'
make[3]: Nothing to be done for `check-am'.
make[3]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/docs/reference'
make[2]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/docs/reference'
make[2]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/docs'
make[2]: Nothing to be done for `check-am'.
make[2]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/docs'
make[1]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/docs'
Making check in idl
make[1]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/idl'
make[1]: Nothing to be done for `check'.
make[1]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/idl'
Making check in libspi
make[1]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/libspi'
make  check-am
make[2]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/libspi'
make[2]: Nothing to be done for `check-am'.
make[2]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/libspi'
make[1]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/libspi'
Making check in registryd
make[1]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/registryd'
make[1]: Nothing to be done for `check'.
make[1]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/registryd'
Making check in atk-bridge
make[1]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/atk-bridge'
make[1]: Nothing to be done for `check'.
make[1]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/atk-bridge'
Making check in cspi
make[1]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/cspi'
Making check in bonobo
make[2]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/cspi/bonobo'
make[2]: Nothing to be done for `check'.
make[2]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/cspi/bonobo'
make[2]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/cspi'
make[2]: Nothing to be done for `check-am'.
make[2]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/cspi'
make[1]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/cspi'
Making check in test
make[1]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/test'
make  check-TESTS
make[2]: Entering directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/test'
Xlib: connection to ":0.0" refused by server
Xlib: No protocol specified


(lt-test-simple:27749): Gtk-WARNING **: cannot open display:
FAIL: test-simple
===================
1 of 1 tests failed
===================
make[2]: *** [check-TESTS] Error 1
make[2]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/test'
make[1]: *** [check-am] Error 2
make[1]: Leaving directory `/var/tmp/portage/at-spi-1.4.2/work/at-spi-1.4.2/test'
make: *** [check-recursive] Error 1

!!! ERROR: gnome-extra/at-spi-1.4.2 failed.
!!! Function src_test, Line 497, Exitcode 0
!!! Make check failed. See above for details.
!!! If you need support, post the topmost build error, NOT this status message.

bash-2.05b# emerge info
Portage 2.0.51_pre15 (default-x86-2004.0, gcc-3.3.3, glibc-2.3.3.20040420-r0, 2.6.7-gentoo-r11 i686 Celeron (Coppermine))
=================================================================
System uname: 2.6.7-gentoo-r11 i686 Celeron (Coppermine)
Gentoo Base System version 1.4.16
distcc 2.13 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [enabled]
ccache version 2.3 [enabled]
Autoconf: sys-devel/autoconf-2.59-r4
Automake: sys-devel/automake-1.8.3
Binutils: sys-devel/binutils-2.14.90.0.8-r1
Headers:  sys-kernel/linux-headers-2.4.21-r1,sys-kernel/linux-headers-2.4.19-r1
Libtools: sys-devel/libtool-1.4.3-r4
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-march=pentium3 -O2 -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.2/share/config /usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config /usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-march=pentium3 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache cvs distcc maketest sandbox sign userpriv usersandbox"
GENTOO_MIRRORS="ftp://mirror.internode.on.net/pub/gentoo             http://premium.planetmirror.com/pub/gentoo             http://gentoo.oregonstate.edu           http://distro.ibiblio.org/pub/linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.au.gentoo.org/gentoo-portage"
USE="X acpi alsa apache2 apm arts artswrappersuid avi berkdb bonobo cdr crypt cups encode ethereal fam fastcgi flash foomaticdb gd gif gtk gtkhtml guile imagemagick imlib java jpeg kde kerberos libgda libwww mad mbox mikmod mmx motif mozilla mpeg mysql nptl ntlm oggvorbis openal operanom2 pam pdflib perl php png ppds python qt quicktime readline samba sdl slp socks5 sox spell sse ssl svga tcltk tetex tiff truetype usb vhosts x86 xinerama xml xml2 xv zlib"

[Comment 1 Mike Gardiner (RETIRED) 2004-08-06 04:41:38 UTC]

I've never seen FEATURES="maketest" - is there some doc we can read on this?

[Comment 2 Daniel Black (RETIRED) 2004-08-06 16:06:55 UTC]

In the later versions of portage FEATURES=maketest causes the src_test routine to be run. By default this cases a "make check" and a "make test" to be attempted. If this fails (as per this bug report) the package is not merged.

Somehow (and I think this is bad logic) but a RESTRICT=maketest will cause it not to be run. A better solution would be to write a src_test routine that performs some internal checking.

[Comment 3 foser (RETIRED) 2004-08-07 05:46:28 UTC]

So should we fix problems with testsuites now ? I don't know if you know it, but in quite a few cases they are the worst maintained part of the sources.

Afaic you just have to disable the FEATURE if its bothersome. I really do not understand why this is by default handled this way.

I'm inclined to close it WONTFIX, because it's another portage feature we haven't asked for and we don't have the time to fix the problems it causes.

[Comment 4 Alastair Tse (RETIRED) 2004-10-17 14:28:03 UTC]

addded RESTRICT to at-spi for now.