Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 592434 - x11-libs/fltk - add multilib support
Summary: x11-libs/fltk - add multilib support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2016-08-30 14:02 UTC by James Le Cuirot
Modified: 2016-09-02 08:56 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-x11-libs-fltk-Multilib-and-other-improvements.patch (0001-x11-libs-fltk-Multilib-and-other-improvements.patch,11.52 KB, patch)
2016-08-30 14:02 UTC, James Le Cuirot
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Le Cuirot gentoo-dev 2016-08-30 14:02:57 UTC
Created attachment 444436 [details, diff]
0001-x11-libs-fltk-Multilib-and-other-improvements.patch

This patch addresses the following:
    
    * EAPI 6
    * Switch from old fdo-mime to newer xdg eclass
    * Add missing libXcursor, libXfixes dependencies
    * Patch to not build unnecessary directories by default
    * Don't install docs for "use games", this was a mistake?
    * Multilib support via multilib-minimal eclass

I did put this on GitHub but I gather jer doesn't like that.

These changes aside, I found that the live Subversion ebuild was failing to authenticate with the remote server even though it works when trying it manually. You may want to figure that out before we revbump it, although I doubt anyone is using that version.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2016-09-02 03:34:29 UTC
Comment on attachment 444436 [details, diff]
0001-x11-libs-fltk-Multilib-and-other-improvements.patch

Um, it's impossible to tell what you change in the ebuilds when you just add files.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2016-09-02 04:25:32 UTC
I am still unsure what could possibly require a non-native FLTK in the first place. Programs that use it normally (statically) link FLTK in, and programs that you can build from source wouldn't need a non-native runtime.
Comment 3 James Le Cuirot gentoo-dev 2016-09-02 08:56:42 UTC
Sorry, hard to know what every dev wants, GitHub or not, ready-to-merge patch or basic diff.

I did this because the Steam runtime includes shared fltk libraries. I haven't encountered any games that require these yet but the number of libraries we're missing (and can feasibly handle) is relatively short now so I thought I'd tick these off.

Unfortunately I didn't notice until after I'd done the work that the runtime has the older 1.1 series rather than 1.3. It seems likely that they'll need to refresh that runtime at some point though, with it being based on Ubuntu 12.04, so we'll be ready for that. I could add a lib-only SLOT for 1.1 but I won't bother unless I find a game that needs it. If you don't want that in the tree, it could live in steam-overlay.

Thanks for merging.