Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 590700 - net-misc/fatrat-1.2.0_beta2[bittorrent] fails to build with >=net-libs/rb_libtorrent-1.0
Summary: net-misc/fatrat-1.2.0_beta2[bittorrent] fails to build with >=net-libs/rb_lib...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: rb_libtorrent-1.0
  Show dependency tree
 
Reported: 2016-08-07 15:47 UTC by Pacho Ramos
Modified: 2022-05-10 19:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2016-08-07 15:47:50 UTC
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp:80:3: warning: #warning NDEBUG defined - please always make sure that libtorrent also has NDEBUG defined [-Wcpp]
 # warning NDEBUG defined - please always make sure that libtorrent also has NDEBUG defined
   ^
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp: In static member function 'static void TorrentDownload::globalInit()':
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp:191:40: warning: 'boost::shared_ptr<libtorrent::torrent_plugin> libtorrent::create_metadata_plugin(libtorrent::torrent*, void*)' is deprecated (declared at /usr/include/libtorrent/extensions/metadata_transfer.hpp:62) [-Wdeprecated-declarations]
  m_session->add_extension(&libtorrent::create_metadata_plugin);
                                        ^
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp: In member function 'virtual QString TorrentDownload::name() const':
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp:472:35: warning: 'std::string libtorrent::torrent_handle::name() const' is deprecated (declared at /usr/include/libtorrent/torrent_handle.hpp:838) [-Wdeprecated-declarations]
   std::string str = m_handle.name();
                                   ^
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp: In member function 'bool TorrentDownload::storeTorrent()':
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp:655:66: warning: 'const libtorrent::torrent_info& libtorrent::torrent_handle::get_torrent_info() const' is deprecated (declared at /usr/include/libtorrent/torrent_handle.hpp:842) [-Wdeprecated-declarations]
  const libtorrent::torrent_info info = m_handle.get_torrent_info();
                                                                  ^
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp: In member function 'virtual void TorrentDownload::load(const QDomNode&)':
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp:925:23: error: no match for 'operator=' (operand types are 'std::vector<char>' and 'std::vector<char>*')
    params.resume_data = &torrent_resume2;
                       ^
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp:925:23: note: candidate is:
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/4.9.3/include/g++-v4/vector:69:0,
                 from /usr/include/qt4/QtCore/qvector.h:52,
                 from /usr/include/qt4/QtGui/qpolygon.h:45,
                 from /usr/include/qt4/QtGui/qmatrix.h:45,
                 from /usr/include/qt4/QtGui/qtransform.h:44,
                 from /usr/include/qt4/QtGui/qimage.h:45,
                 from /usr/include/qt4/QtGui/qpixmap.h:50,
                 from /usr/include/qt4/QtGui/qicon.h:48,
                 from /usr/include/qt4/QtGui/QIcon:1,
                 from /var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/fatrat.h:37,
                 from /var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp:28:
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.3/include/g++-v4/bits/vector.tcc:167:5: note: std::vector<_Tp, _Alloc>& std::vector<_Tp, _Alloc>::operator=(const std::vector<_Tp, _Alloc>&) [with _Tp = char; _Alloc = std::allocator<char>]
     vector<_Tp, _Alloc>::
     ^
/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.3/include/g++-v4/bits/vector.tcc:167:5: note:   no known conversion for argument 1 from 'std::vector<char>*' to 'const std::vector<char>&'
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp: In member function 'void TorrentWorker::processAlert(libtorrent::alert*)':
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp:1355:75: warning: 'const libtorrent::torrent_info& libtorrent::torrent_handle::get_torrent_info() const' is deprecated (declared at /usr/include/libtorrent/torrent_handle.hpp:842) [-Wdeprecated-declarations]
     d->m_info = new libtorrent::torrent_info(d->m_handle.get_torrent_info());
                                                                           ^
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp: In member function 'void TorrentWorker::doWork()':
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDownload.cpp:1392:74: warning: 'const libtorrent::torrent_info& libtorrent::torrent_handle::get_torrent_info() const' is deprecated (declared at /usr/include/libtorrent/torrent_handle.hpp:842) [-Wdeprecated-declarations]
    d->m_info = new libtorrent::torrent_info(d->m_handle.get_torrent_info());
                                                                          ^
CMakeFiles/fatrat.dir/build.make:2788: recipe for target 'CMakeFiles/fatrat.dir/src/engines/TorrentDownload.cpp.o' failed
make[2]: *** [CMakeFiles/fatrat.dir/src/engines/TorrentDownload.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDetails.cpp: In member function 'void TorrentDetails::peerInfo()':
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentDetails.cpp:144:88: error: 'const struct libtorrent::peer_info' has no member named 'load_balancing'
   QMessageBox::information(treePeers, "FatRat", QString("Load balancing: %1").arg(info.load_balancing));
                                                                                        ^
CMakeFiles/fatrat.dir/build.make:2764: recipe for target 'CMakeFiles/fatrat.dir/src/engines/TorrentDetails.cpp.o' failed
make[2]: *** [CMakeFiles/fatrat.dir/src/engines/TorrentDetails.cpp.o] Error 1
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentOptsWidget.cpp: In member function 'virtual void TorrentOptsWidget::load()':
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentOptsWidget.cpp:95:83: warning: 'libtorrent::torrent_info::file_iterator libtorrent::torrent_info::begin_files() const' is deprecated (declared at /usr/include/libtorrent/torrent_info.hpp:490) [-Wdeprecated-declarations]
  for(libtorrent::torrent_info::file_iterator it = m_download->m_info->begin_files();
                                                                                   ^
/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2/src/engines/TorrentOptsWidget.cpp:96:39: warning: 'libtorrent::torrent_info::file_iterator libtorrent::torrent_info::end_files() const' is deprecated (declared at /usr/include/libtorrent/torrent_info.hpp:492) [-Wdeprecated-declarations]
   it != m_download->m_info->end_files();
                                       ^
make[2]: Leaving directory '/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2_build'
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/fatrat.dir/all' failed
make[1]: *** [CMakeFiles/fatrat.dir/all] Error 2
make[1]: Leaving directory '/var/tmp/portage/net-misc/fatrat-1.2.0_beta2/work/fatrat-1.2.0_beta2_build'
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2
Comment 2 Davide Pesavento (RETIRED) gentoo-dev 2016-08-10 03:03:21 UTC
(In reply to Jan Chren (rindeal) from comment #1)
> https://github.com/LubosD/fatrat/issues/35

No, that's for rb_libtorrent-1.1.x. This bug is against 1.0.x.

This commit should be backported (untested): https://github.com/LubosD/fatrat/commit/21f602842b99664132a91dbf67378b8e1671c719

Considering that fatrat hasn't seen a release in more than 4 years, a snapshot from git would make a lot of sense too.
Comment 3 Davide Pesavento (RETIRED) gentoo-dev 2016-08-18 20:42:05 UTC
Ping, this is blocking a security stabilization, can we get it fixed ASAP?
Comment 4 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-08-22 12:04:09 UTC
commit ba9d638dd54bca0b733b097a1124fe338d1e6740
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Mon Aug 22 14:01:18 2016

    net-misc/fatrat: Bump to git snapshot for bug #590700.
    
    Package-Manager: portage-2.3.0
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>


The snapshot is named net-misc/fatrat-1.2.0_beta2_p20150803 and should fix this issue.