Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 59004 - ufed-0.34 makes some use flags as --flag instead of -flag.
Summary: ufed-0.34 makes some use flags as --flag instead of -flag.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
: 60342 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-07-31 10:04 UTC by Marc-Éric Dupuis
Modified: 2004-11-21 21:48 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ufed-0.35-checkdefaults.patch (ufed-0.35-checkdefaults.patch,526 bytes, patch)
2004-11-08 16:48 UTC, Harald van Dijk (RETIRED)
Details | Diff
ufed-0.35-checkdefaults.patch (ufed-0.35-checkdefaults.patch,526 bytes, patch)
2004-11-08 17:01 UTC, Harald van Dijk (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-Éric Dupuis 2004-07-31 10:04:26 UTC
This is a fresh installation on an athlon64. When I use ufed it turns some of my -flag into --flag. Now I just corrected the errors in my make.conf so my USE line is this:

USE="escreen fbcon javascript moznocompose moznoirc moznomail -arts -cups -java -nptl -kde -gnome -motif -qt -directfb"

Now I start ufed to add a flag, dvd for this exemple. My USE flag becomes this:

USE="dvd escreen fbcon javascript moznocompose moznoirc moznomail -arts \
     --cups --java --nptl -kde -gnome -motif --qt -directfb"

I correct my USE line again so it is like it was at first by removing dvd and the extra "-". After I open ufed and just press save my USE becomes:

USE="escreen fbcon javascript moznocompose moznoirc moznomail -arts --cups \
     --java --nptl -kde -gnome -motif --qt -directfb"

The same errors reappears at the same places. Re-emerging ufed did not solve this.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.




Emerge info:

Gentoo Base System version 1.4.16
Portage 2.0.50-r9 (default-amd64-2004.2, gcc-3.3.3, glibc-2.3.4.20040605-r0,
2.6.7-gentoo-r11)
=================================================================
System uname: 2.6.7-gentoo-r11 x86_64 12
Autoconf: sys-devel/autoconf-2.59-r3
Automake: sys-devel/automake-1.8.3
ACCEPT_KEYWORDS="amd64"
AUTOCLEAN="yes"
CFLAGS="-O2"
CHOST="x86_64-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3/share/config /usr/lib/mozilla/defaults/pref /usr/share/config
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache"
GENTOO_MIRRORS="http://mirror.datapipe.net/gentoo http://mirrors.tds.net/gentoo
ftp://ftp.gtlib.cc.gatech.edu/pub/gentoo http://mir.zyrianes.net/gentoo/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X alsa amd64 apm avi berkdb crypt encode escreen esd fbcon foomaticdb gdbm
gif gphoto2 gpm gtk gtk2 imlib javascript jpeg libg++ libwww mikmod mozilla
moznocompose moznoirc moznomail mpeg ncurses nls nogcj oggvorbis opengl oss pam
pdflib perl png python quicktime readline sdl slang spell ssl tcpd truetype xml2
xmms xv zlib"
Comment 1 Marius Mauch (RETIRED) gentoo-dev 2004-10-06 11:55:00 UTC
*** Bug 60342 has been marked as a duplicate of this bug. ***
Comment 2 Harald van Dijk (RETIRED) gentoo-dev 2004-11-08 16:48:27 UTC
Created attachment 43561 [details, diff]
ufed-0.35-checkdefaults.patch

ufed assumes that no flags are disabled in make.defaults, which is true for all
profiles except some amd64 and mips profiles. Your profile has -java as a
default use flag, and ufed assumes that this sets the "-java" use flag.
Attached patch should fix it.
Comment 3 Harald van Dijk (RETIRED) gentoo-dev 2004-11-08 16:51:07 UTC
Comment on attachment 43561 [details, diff]
ufed-0.35-checkdefaults.patch

>--- ufed-0.35.orig/ufed.pl
>+++ ufed-0.35/ufed.pl
>@@ -672,7 +672,8 @@
>    #$All = "Make.def : " . join(' ', @make_defaults_flags) . "\n";
> 
>    #Step 2)
>-   $Results =  resolve_flags(join (' ', @make_defaults_flags),
>-                             join (' ', @use_defaults_flags));
>+   $Results =  resolve_flags(resolve_flags('',
>+                             join (' ', @make_defaults_flags)),
>+                             join (' ', @use_defaults_flags));
> 
>    #$All .= "Use.def : " . join(' ', @use_defaults_flags) . "\n";
Comment 4 Harald van Dijk (RETIRED) gentoo-dev 2004-11-08 17:01:00 UTC
Created attachment 43563 [details, diff]
ufed-0.35-checkdefaults.patch

I placed parentheses in the wrong place for the original patch and tried to
correct it. I'll attach the modified and hopefully correct patch in case
there's a problem with spacing copying it from my previous comment. Sorry for
the multiple comments.
Comment 5 Marius Mauch (RETIRED) gentoo-dev 2004-11-21 21:48:58 UTC
0.35-r2 with the patch is in CVS now.