Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 590006 - media-gfx/gimp incorrect RDEPEND on dev-util/gdbus-codegen
Summary: media-gfx/gimp incorrect RDEPEND on dev-util/gdbus-codegen
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sebastian Pipping
URL:
Whiteboard:
Keywords: QAbaddep
Depends on:
Blocks:
 
Reported: 2016-07-29 15:51 UTC by Mart Raudsepp
Modified: 2016-07-29 17:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2016-07-29 15:51:27 UTC
https://qa-reports.gentoo.org/output/genrdeps/rindex/dev-util/gdbus-codegen as pointed out by mgorny tells that most or all versions/revisions of gimp are RDEPENDing on gdbus-codegen.
It is highly unlikely that it is needed at runtime, as gdbus-codegen is a build time tool to generate D-Bus code from an dbus interface description during the build process.
Please review and adjust to only DEPEND if indeed appropriate, as is likely (unless it actually doesn't use the tool at all during build time - that might be from release tarballs if the code is pregenerated into tarball, and autoreconf alike stuff doesn't get ran).
Comment 1 Sebastian Pipping gentoo-dev 2016-07-29 17:16:06 UTC
Hi Mart,

good catch: the generated files are part of the tarball already, so 9999 needs it for DEPEND, the others don't.  Post-commit review welcome.  If you see something odd, please re-open.


commit d749367fa7030bb9f71707d775219d16029255d1
Author: Sebastian Pipping <sping@g.o>
Date:   Fri Jul 29 18:48:05 2016 +0200

    media-gfx/gimp: Fix dep on gdbus-codegen (bug #590006)
    
    Package-Manager: portage-2.2.28

 media-gfx/gimp/gimp-2.9.2-r2.ebuild | 6 +++++-
 media-gfx/gimp/gimp-2.9.4.ebuild    | 6 +++++-
 media-gfx/gimp/gimp-9999.ebuild     | 2 +-
 3 files changed, 11 insertions(+), 3 deletions(-)

https://github.com/gentoo/gentoo/commit/d749367fa7030bb9f71707d775219d16029255d1