589490 – net-fs/openafs-kernel: use of REPLACING_VERSIONS does not account for multiple values

Bug 589490 - net-fs/openafs-kernel: use of REPLACING_VERSIONS does not account for multiple values

Summary: net-fs/openafs-kernel: use of REPLACING_VERSIONS does not account for multipl...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal QA (vote)
Assignee:	Adam Feldman

URL:
Whiteboard:
Keywords:	QAcanfix

Depends on:
Blocks:	589444
	Show dependency tree

Reported:	2016-07-23 12:50 UTC by Michał Górny
Modified:	2016-07-23 22:01 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2016-07-23 12:50:28 UTC

See the tracker bug.

  if use kernel_linux && [[ ${REPLACING_VERSIONS} < "1.6.18.2" ]]; then

This doesn't account for empty RV or having >1 value. Furthermore, < is lexicographical string comparison, so e.g. 10 < 2 is true.

Comment 1 Andrew Savchenko gentoo-dev

2016-07-23 14:15:14 UTC

This line is absent in the ebuild for more than a day already since commit a20b9d2daf91d342b50d255e4815e3a7f818b9ac

Please use up-to-date tree.

Comment 2 Michał Górny archtester

2016-07-23 15:16:24 UTC

Very well.

  if use kernel_linux && ! version_is_at_least 1.6.18.2 ${REPLACING_VERSIONS}; then

Does the new snippet convince you to the fix the issue at hand?

Comment 3 Andrew Savchenko gentoo-dev

2016-07-23 22:01:50 UTC

in git