Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 589440 - media-plugins/gst-plugins-opus-1.8.2 does not provide opus support (migration to -base)
Summary: media-plugins/gst-plugins-opus-1.8.2 does not provide opus support (migration...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: GStreamer package maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-23 10:40 UTC by Nils Freydank
Modified: 2016-09-25 20:01 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed patch for media-plugins/gst-plugins-opus-1.8.2 (gst-plugins-base-1.8.2-r1.patch,1.29 KB, patch)
2016-07-23 10:51 UTC, Nils Freydank
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nils Freydank 2016-07-23 10:40:36 UTC
Hello,

gst-plugins-opus-1.8.2 doesn’t provide the opus plugins for gstreamer. However,
gst-plugins-opus-1.6.3 still work “the old way“.

After some digging it looks that the opus support is now in gst-plugins-base-1.8.2. There came the suggestion to entirely remove gst-plugins-opus-1.8.2, add USE="opus" to gst-plugins-base-1.8.2, and put the remaining plugin libgstopusparse into gst-plugins-bad-1.8.2.
Thanks to stkn for that!

Greetings,
holgersson

Reproducible: Always
Comment 1 Nils Freydank 2016-07-23 10:44:00 UTC
See also (Release Notes):
https://gstreamer.freedesktop.org/releases/1.8/
Comment 2 Nils Freydank 2016-07-23 10:51:29 UTC
Created attachment 441418 [details, diff]
Proposed patch for media-plugins/gst-plugins-opus-1.8.2
Comment 3 Pacho Ramos gentoo-dev 2016-07-31 08:51:03 UTC
[master ced7664] media-libs/gst-plugins-base: Enable opus support (#589440 by holgersson)
 2 files changed, 6 insertions(+), 2 deletions(-)
Comment 4 Mart Raudsepp gentoo-dev 2016-09-23 04:13:50 UTC
Reopening, as this should have probably been a conversion of gst-plugins-opus to use GST_ORG_MODULE=gst-plugins-base instead of USE flaggery on main -base.
Need to look at that before 1.8 series goes stable. The complex bit is on deciding what to do with the parser bits that remaining in -bad for now. Need to see if that's even useful in any way if it was left behind, etc.
So this open bug is a reminder for looking into this.
Comment 5 Mart Raudsepp gentoo-dev 2016-09-23 19:25:06 UTC
yup, checked with upstream:

<leio> Is opusparse important for opus pipelines, despite being left in -bad for now?
<__tim> no
<leio> So the glorious Opus codec world doesn't end in Gentoo if I axe opusparse plugin from -bad completely for now?
<__tim> it doesn't, no
<leio> now beyond packaging, what does it do then? :)
<__tim> I think it's supposed to parse the test streams which are framed slightly differently, but last I checked it didn't match the spec for those, so it's all a bit puzzling really


So we should forget about the gst-plugins-bad ext/opus/, have gst-plugins-opus GST_ORG_MODULE=gst-plugins-base and kill it from -base.
And then stable that, not this moving around.
Comment 6 Mart Raudsepp gentoo-dev 2016-09-25 20:01:26 UTC
If you got rid of gst-plugins-opus based on the blockers and whatnot before, you should install it again to have opus decoder and encoder.

commit 9ff9335c2b024f4c49f20c9ddb8066dd8a661f45
Author: Mart Raudsepp <leio@gentoo.org>
Date:   Sun Sep 25 22:29:08 2016 +0300

    media-plugins/gst-plugins-opus: Properly split again
    
    ... instead of building as part of gst-plugins-base[opus].
    This makes gst-plugins-opus a split of -base instead of -bad as it
    was moved from -base to -bad with some leftovers in -bad.
    The ext/opus/ leftover part in gst-plugins-bad is not necessary
    for anything and we can safely not package that at all.
    This should give a nicer upgrade path for stable opus plugin users.
    
    Gentoo-bug: 589440