I've just updated x11-base/xorg-server from 1.16.4 to 1.17.4 and found a possible missing dependency. If USE="xnest" is used, and x11-libs/xcb-util-keysyms is not installed, then the build of xorg-server-1.17.4 fails with: /var/tmp/portage/x11-base/xorg-server-1.17.4/work/xorg-server-1.17.4/hw/xnest/Keyboard.c:25:29: fatal error: xcb/xcb_keysyms.h: No such file or directory #include <xcb/xcb_keysyms.h> If x11-libs/xcb-util-keysyms is installed, or USE="-xnest" then it builds fine. I don't know if the new dependency is really required, or if something from USE="xephyr" is leaking through. Unfortunately this is a production machine with very low specs, so I can't spend the time to test things (source code patches, other versions of xorg-server) & recompile to see if they work. The patch submitted adds the dependency for USE="xnest". If this is really a new requirement for xorg-server, then the same should be done to the ebuilds of newer versions.
Created attachment 437696 [details] build log
Created attachment 437698 [details] emerge info
Created attachment 437700 [details, diff] ebuild patch
(No need to Cc yourself on bugs you file) Currently hostx.c and ephyr.c are the only two files that #include xcb/xcb_keysyms.h. They are both part of Xephyr, not Xnest. I fixed the missing xcb dependencies a couple of years ago in the x11 overlay, with commit ad669de599c69a5436683f2acd22de49d66af118 Author: Matt Turner <mattst88@gmail.com> Date: Sat Feb 21 18:31:20 2015 -0800 x11-base/xorg-server: Set appropriate xcb dependencies for xephyr. The ebuild is now in the main portage tree, and all versions going back to 1.17.4 have that dependency. But your report says Keyboard.c is the culprit. I checked the xserver git log, and xcb/xcb_keysyms.h was included until commit 4affa75a90d2455c81087b930126ad7adfd019f0 Author: Adam Jackson <ajax@redhat.com> Date: Thu Nov 19 12:21:08 2015 -0500 xnest: Fix needless build dependency on xcb-util-keysyms which is in 1.19.0. I have fixed the 1.17.4 and 1.18.4 ebuilds to contain the dependency: commit 0a24e95351f1619d93dd1c8598c49647a964b587 Author: Matt Turner <mattst88@gentoo.org> Date: Sat Feb 25 21:02:20 2017 -0800 x11-base/xorg-server: Depend on xcb-util-keysyms for xnest. Thanks for the bug report.
