Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 582992 - www-servers/nginx: nginx_modules_http_upstream_check triggers segmentation fault (upstream issue 49)
Summary: www-servers/nginx: nginx_modules_http_upstream_check triggers segmentation fa...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Tiziano Müller (RETIRED)
URL: https://github.com/yaoweibin/nginx_up...
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2016-05-14 08:29 UTC by Zac Medico
Modified: 2016-05-15 21:27 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zac Medico gentoo-dev 2016-05-14 08:29:15 UTC
There's another ngx_http_upstream_check_find_shm_peer segfault similar to bug 582316, with this upstream issue and working patch:

https://github.com/yaoweibin/nginx_upstream_check_module/issues/49
https://github.com/yaoweibin/nginx_upstream_check_module/commit/d0e92fa05900e8232e8bfcc1c1ca7d2c3eb184b6

The commit message doesn't mention issue 49, but afterwards the author commented on issue 49:

> I remove some suspicious code. Hope this can help you. Try the latest master branch.
Comment 2 Manuel Rüger (RETIRED) gentoo-dev 2016-05-15 21:20:10 UTC
Zac: Thanks for your help. But could you get your changes into a process, that is reviewable? You fixed a runtime-only error, but you haven't revbumped the ebuild, which is not the best idea, as not everyone gets the fix now.
Comment 3 Zac Medico gentoo-dev 2016-05-15 21:27:26 UTC
(In reply to Manuel Rüger from comment #2)
> Zac: Thanks for your help. But could you get your changes into a process,
> that is reviewable? You fixed a runtime-only error, but you haven't
> revbumped the ebuild, which is not the best idea, as not everyone gets the
> fix now.

I'm just not convinced that anyone was actually using this plugin, since the segfault has been there for over a year, with a fix just sitting upstream.