582200 – sys-kernel/ck-sources: use calls in global scope

Bug 582200 - sys-kernel/ck-sources: use calls in global scope

Summary: sys-kernel/ck-sources: use calls in global scope

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal major
Assignee:	Ben de Groot (RETIRED)

URL:
Whiteboard:
Keywords:	QAcanfix

Depends on:
Blocks:	global-scope-use
	Show dependency tree

Reported:	2016-05-05 20:54 UTC by Michał Górny
Modified:	2016-05-24 18:14 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Proposed fix (update.patch,1.55 KB, patch) 2016-05-06 21:05 UTC, Ian Stakenvicius (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2016-05-05 20:54:31 UTC

Calling 'use' in global scope is forbidden and will be banned completely soon. Please fix the ebuilds to do all 'use' conditionals in phase functions.

Comment 1 Michał Górny archtester

2016-05-06 16:40:23 UTC

Furthermore, DISTDIR is also forbidden in global scope.

Comment 2 Ian Stakenvicius (RETIRED) gentoo-dev

2016-05-06 21:05:55 UTC

Created attachment 433446 [details, diff]
Proposed fix

This attachment is a potential fix to the issues.  I haven't tested it but after reading through kernel-2.eclass it looks like src_unpack() is the only place that the UNIPATCH stuff would be used from in this particular ebuild.

Comment 3 Michał Górny archtester

2016-05-20 21:17:15 UTC

Ian, could you merge your patch, please? This will already cause fatal issues with git portage.

Comment 4 Ian Stakenvicius (RETIRED) gentoo-dev

2016-05-24 18:14:36 UTC

patch committed.