Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 576946 - media-sound/kid3-3.3.1: unable to view or edit metadata
Summary: media-sound/kid3-3.3.1: unable to view or edit metadata
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-10 11:28 UTC by BT
Modified: 2016-03-23 14:48 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge.info,5.37 KB, text/plain)
2016-03-10 11:28 UTC, BT
Details
build.log (build.log,980.96 KB, text/x-log)
2016-03-10 11:28 UTC, BT
Details
modified libdir.patch (file_576946.txt,889 bytes, patch)
2016-03-16 20:29 UTC, jjtt
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BT 2016-03-10 11:28:07 UTC
I'm unable to view or edit metadata for any of my audio files (.flac, .m4a) with Kid3 3.3.1. Also there are no plugins listed in "Settings->Configure Kid3->Plugins".
Comment 1 BT 2016-03-10 11:28:29 UTC
Created attachment 427872 [details]
emerge --info
Comment 2 BT 2016-03-10 11:28:55 UTC
Created attachment 427874 [details]
build.log
Comment 3 Till Schäfer 2016-03-10 22:32:00 UTC
may this be related to plugins, being not detected correctly?

i do not see a single plugin in kid3 settings.
Comment 4 Jared B. 2016-03-11 07:21:25 UTC
FYI, I'm having the same problem.  Same symptoms described by both previous commenters.  So far no luck troubleshooting.
Comment 5 Jared B. 2016-03-13 06:04:05 UTC
So... still having this problem.  I've tried downgrading to 3.2.1-r1, but get the exact same behavior.  I tried downgrading to 3.1.2, which was the version I was using before this upgrade, I can no longer build it.  The configure terminates with the snippet posted at the end (I can include the full logs if requested; not doing so now since this is tangential to the bug report).

I'm running kde/plasma 5, using the keywords files from the kde overlay.  I just did a full system update, revdep-rebuild, etc., and I'm still unable to find anything that should be causing this.

Anyone else have any better luck?



CMake Error at /usr/share/apps/cmake/modules/FindKDE4Internal.cmake:1471 (add_custom_target):
  add_custom_target cannot create target "uninstall" because another target
  with the same name already exists.  The existing target is a custom target
  created in source directory
  "/tmp/portage/media-sound/kid3-3.1.2/work/kid3-3.1.2/src/app".  See
  documentation for policy CMP0002 for more details.
Call Stack (most recent call first):
  /usr/share/cmake/Modules/FindKDE4.cmake:108 (find_package)
  doc/en/CMakeLists.txt:2 (find_package)


-- <<< Gentoo configuration >>>
Build type      Gentoo
Install path    /usr
Compiler flags:
C               -march=native -O2 -pipe  -Wundef -Wcast-align -Wall -W -Wpointer-arith -D_REENTRANT -fvisibility=hidden
C++             -march=native -O2 -pipe  -Wundef -Wcast-align -Wall -W -Wpointer-arith -fno-check-new -fno-common -D_REENTRANT -Woverloaded-virtual -fvisibility=hidden -fvisibility-inlines-hidden
Linker flags:
Executable       -Wl,-O1 -Wl,--as-needed
Module           -Wl,-O1 -Wl,--as-needed
Shared           -Wl,-O1 -Wl,--as-needed
Comment 6 Frank Steinmetzger 2016-03-13 23:55:27 UTC
Here's a "me too". There are a number of plugins installed into /usr/lib64/qt4/plugins/kid3. But according to `strace -e file kid3`, it never looks in there. I couldn't find any mentioning of "kid3" in the strace output that wasn't "kid3rc".

I'm still on stable KDE4, amd64.
Comment 7 Gramiel 2016-03-15 16:09:29 UTC
I do not have a Gentoo installation, but I think that I found the problem:

In files/kid3-3.2.1-libdir.patch, there is a line at the bottom which sets the WITH_PLUGINSDIR CMake variable:

 +  set(WITH_PLUGINSDIR "${WITH_LIBDIR_DEFAULT}/${QTVER}/plugins/kid3")

This will modify the original CMakeLists.txt around line 400. The problem here is that the variable WITH_PLUGINSDIR is used before at line 203:

file(RELATIVE_PATH CFG_PLUGINSDIR /${WITH_BINDIR} /${WITH_PLUGINSDIR})

This sets the variable CFG_PLUGINSDIR to a path to the plugins directory relative to the directory where the kid3 binary is located. This variable will then be used to generate the header file config.h with a #define CFG_PLUGINSDIR, which is used at runtime to locate the plugins. In the current situation, CFG_PLUGINSDIR and the later modified WITH_PLUGINSDIR (which is used to install the plugins) use different directories, the plugins will not be searched where they are installed.

To fix this, I would recommend to remove this kid3-3.2.1-libdir.patch. It only modifies CMake variables which can be passed to cmake, so in the kid3-3.3.1.ebuild remove the line

PATCHES=( "${FILESDIR}/${PN}-3.2.1-libdir.patch" )

and add additional cmake variable definitions after "-DWITH_QT5=OFF":

-DWITH_LIBDIR=lib$LIB_SUFFIX -DWITH_PLUGINSDIR=lib$LIB_SUFFIX/qt4/plugins/kid3

This should do the same thing as the patch, but as I said, I could not test it, and I am not sure if LIB_SUFFIX is set and if it can be used like this in the ebuild.
Comment 8 Jared B. 2016-03-15 19:00:10 UTC
(In reply to Gramiel from comment #7)
> I do not have a Gentoo installation, but I think that I found the problem:

Wow, thanks for the suggestion.  I just tried it out and it seems to work fine.  I've not tested exhaustively, but tags do show up now and the plugins display in the settings.  I'll give it a more thorough test later (including actually modifying tags) and report back if there are any negative results.

Thanks, Gramiel.  Greatly appreciate the help.
Comment 9 Jared B. 2016-03-16 01:35:55 UTC
Yep, it works great.  Had to reset some preferences (looks like this version switched over to KDE Frameworks 5 and it didn't migrate the KDE 4 settings), but otherwise everything is working as expected.

Thanks again for the help.
Comment 10 jjtt 2016-03-16 20:29:48 UTC
Created attachment 428382 [details, diff]
modified libdir.patch

kid3 would not compile for me with Gramiels solution, so I modified the patch.

Getting rid of the patch would be a better way to fix this.
Comment 11 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2016-03-23 14:48:15 UTC
commit 45f421bb8ef5ba6193b15d4fbe519dc1785fb00c
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Wed Mar 23 15:46:28 2016

    media-sound/kid3: Fixed location of plugins dir (bug #576946).
    
    Thanks to Gramiel <gentoo.bugs@mailinator.com> for findinf the root
    cause and to jjtt <jjtt@mbnet.fi> for providing a patch.
    
    Package-Manager: portage-2.2.28
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>


Fixed in =media-sound/kid3-3.3.2-r1