Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 575868 - app-emulation/xen-4.6.1 build failure
Summary: app-emulation/xen-4.6.1 build failure
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Xen Devs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-28 05:26 UTC by Pat Erley
Modified: 2016-04-14 12:07 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix compile failure (xen-4.6.1-grant_table_comment_fix.patch,684 bytes, patch)
2016-02-28 05:26 UTC, Pat Erley
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pat Erley 2016-02-28 05:26:48 UTC
Created attachment 426826 [details, diff]
Patch to fix compile failure

There seems to be corruption in the upstream tarball.  include/public/grant_table.h has some 'corrupt' characters in one of it's comments, leading to gcc not detecting the end of the comment block.  The attached patch fixes compilation on my system.

The corruption does not appear in the git tree, so it must have been introduced during the generation of the tarball.
Comment 1 Pat Erley 2016-02-28 05:27:42 UTC
Ahhh, viewing the patch in browser, it's a smart quote.
Comment 2 Pat Erley 2016-02-28 05:28:52 UTC
http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=3f293c7caaefc2c37b61e44e8ebd5a7f1c554afb

Upstream fix... should be rolled into the ebuild.
Comment 3 Pat Erley 2016-03-06 08:48:22 UTC
For anyone concerned with backporting the upstream fix, there is exactly zero risk as it only affects a comment with a smart quote that grep isn't smart enough to parse correctly.
Comment 4 Ian Delaney (RETIRED) gentoo-dev 2016-04-14 12:07:55 UTC
commit 5e3265d6af09ae438104fc24c8e8537c4c235061
Author: Ian Delaney <idella4@gentoo.org>
Date:   Thu Apr 14 20:00:50 2016 +0800

    app-emulation/xen-tools: correct typo in source of vn. 4.6.1
    
    noted in gentoo bug, set with an equivalent sed statement substituting
    an upstream patch, the sed being completed in one line
    
    Gentoo-bug: #575868
    
commit e7f4ae036081464c52eb4bd8d61baf87dd4478d5
Author: Ian Delaney <idella4@gentoo.org>
Date:   Thu Apr 14 19:59:09 2016 +0800

    app-emulation/xen: correct typo in source of vn. 4.6.1
    
    noted in gentoo bug, set with an equivalent sed statement substituting
    an upstream patch, the sed being completed in one line
    
    Gentoo-bug: #575868