Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 575124 - app-misc/ca-certificates: improve pkg_postinst messages
Summary: app-misc/ca-certificates: improve pkg_postinst messages
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-02-19 08:01 UTC by Michael Palimaka (kensington)
Modified: 2016-04-22 18:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ca-certificates-pkgpostinst.patch (ca-certificates-pkgpostinst.patch,764 bytes, patch)
2016-02-19 08:01 UTC, Michael Palimaka (kensington)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Palimaka (kensington) gentoo-dev 2016-02-19 08:01:59 UTC
Created attachment 425872 [details, diff]
ca-certificates-pkgpostinst.patch

The current pkg_postinst messages are a bit verbose/untidy in my opinion. Attached patch suggests some improvements:

* Drop broken symlink message (it's duplicated in the removal notice)
* Removing leading slash (PMS suggests that EROOT has a trailing slash)
* Indent list of removals under heading

Before:
 * Broken symlink for a certificate at /etc/ssl/certs/bar1
 * Broken symlink for a certificate at /etc/ssl/certs/bar2
 * Broken symlink for a certificate at /etc/ssl/certs/bar3
 * Broken symlink for a certificate at /etc/ssl/certs/bar6
 * Broken symlink for a certificate at /etc/ssl/certs/bar9
 * Broken symlink for a certificate at /etc/ssl/certs/bar4
 * Broken symlink for a certificate at /etc/ssl/certs/bar7
 * Broken symlink for a certificate at /etc/ssl/certs/bar8
 * Broken symlink for a certificate at /etc/ssl/certs/bar5
 * Removing the following broken symlinks:
 * //etc/ssl/certs/bar1 -> /foo
 * //etc/ssl/certs/bar2 -> /foo
 * //etc/ssl/certs/bar3 -> /foo
 * //etc/ssl/certs/bar6 -> /foo
 * //etc/ssl/certs/bar9 -> /foo
 * //etc/ssl/certs/bar4 -> /foo
 * //etc/ssl/certs/bar7 -> /foo
 * //etc/ssl/certs/bar8 -> /foo
 * //etc/ssl/certs/bar5 -> /foo

After:
 * Removing the following broken symlinks:
 *      /etc/ssl/certs/bar1 -> /foo
 *      /etc/ssl/certs/bar2 -> /foo
 *      /etc/ssl/certs/bar3 -> /foo
 *      /etc/ssl/certs/bar6 -> /foo
 *      /etc/ssl/certs/bar9 -> /foo
 *      /etc/ssl/certs/bar4 -> /foo
 *      /etc/ssl/certs/bar7 -> /foo
 *      /etc/ssl/certs/bar8 -> /foo
 *      /etc/ssl/certs/bar5 -> /foo
Comment 1 SpanKY gentoo-dev 2016-02-19 08:50:44 UTC
the first for loop is kind of pointless now.  you should just change it to like a non-empty string test or something.