Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 574806 - media-video/mplayer-1.2.1: add vcd and yuv4mpeg USE flags
Summary: media-video/mplayer-1.2.1: add vcd and yuv4mpeg USE flags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2016-02-15 16:57 UTC by nobody
Modified: 2016-03-04 10:04 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
mplayer-1.2.1-vcd-yuv4mpeg-flags.diff (mplayer-1.2.1-vcd-yuv4mpeg-flags.diff,1.43 KB, patch)
2016-02-15 16:57 UTC, nobody
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description nobody 2016-02-15 16:57:17 UTC
Created attachment 425574 [details, diff]
mplayer-1.2.1-vcd-yuv4mpeg-flags.diff

This flags are needed to disable some unnecessary features.
Check the patch. Maybe yuv4mpeg flag should be renamed, etc.
Comment 1 Alexis Ballier gentoo-dev 2016-02-24 14:22:08 UTC
what is the gain in disabling these ?
Comment 2 nobody 2016-03-01 09:29:33 UTC
Binary file is just ~10KB smaller, but I think user should be able to disable anything he wants. Maybe it's wrong opinion.
Comment 3 Alexis Ballier gentoo-dev 2016-03-01 10:10:11 UTC
(In reply to nobody from comment #2)
> but I think user should be able to
> disable anything he wants.

I tend to agree with that, but I also think having too many useflags does not help (mplayer has quite a bunch of them already and could probably gain a few dozens more): it becomes very hard to distinguish between what provides a real gain and what is almost irrelevant.

anyway, I have nothing against it, but please submit a more complete patch, ideally a github pull request:
- metadata.xml change with use descriptions is missing
- ebuild updates for mplayer are first made to -9999 and then backported to releases; you can do all the changes in one commit, but yours is missing -9999 update
Comment 4 Alexis Ballier gentoo-dev 2016-03-04 10:04:01 UTC
PR merged, thanks!