Bug 574064 – =media-video/vlc-2.2.2: Please bump for testing.

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Jeremy Murphy 2016-02-07 08:29:48 UTC]

I know this tarball only dropped yesterday, but I'm keen to see 2.2.2 in portage so I'm mentioning it right away.  :)

[Comment 1 Jouni Kosonen 2016-02-07 16:56:45 UTC]

Four of the patches in vlc-2.2.1-r1 have been applied upstream, but there is no test for the fix for QTBUG-48321. The configuration of version 2.2.2 forcibly fails the build with Qt 5.5.1 when USE="qt5".

In Gentoo that fix is backported in bug #563458.

I made a pull request 811 for this but just realized that I probably wasn't supposed to raise the qt dependency at the same time.

[Comment 2 Adam Feldman 2016-02-07 22:39:15 UTC]

(In reply to Jeremy Murphy from comment #0)
> I know this tarball only dropped yesterday, but I'm keen to see 2.2.2 in
> portage so I'm mentioning it right away.  :)

Please don't 0-day version bump request.  There is a good chance the maintainer is aware of it, and sending an email the instant it comes out is likely only to be counter productive.

[Comment 3 Nick Andrade 2016-02-08 07:35:57 UTC]

Thanks NP, yep, I'm actively working on it and hope to have something released for unstable this week.  If you're look for the latest, the recently cleaned up 9999 ebuild works well (I've been using it the last couple weeks).  I do appreciate the enthusiasm for VLC.

[Comment 4 Nick Andrade 2016-02-08 08:16:38 UTC]

Created attachment 424874 [details]
vlc-2.2.2.ebuild

Since there are eager testers, attached is a first attempt at a release of the 2.2.2 ebuild.  

The following patches from 2.2.1-r1 have been removed:
bug 542414 - vlc-2.2.0-rdp-1.2.0.patch
bug 541928 - vlc-2.2.0-xcb_vdpau.patch
bug 554562 - opencv-3.0.0.patch
bug for CVE-2015-5949 - vlc-CVE-2015-5949.patch

The following patch was added to allow for QT5 builds since Gentoo uses a patched version of qt5widgets (no need to backport): vlc--2.2.2-qt5widgets.patch

To check what version of QT vlc is built with, run "scanelf -n /usr/lib/vlc/plugins/gui/libqt4_plugin.so" (note: the file is always called libqt4_plugin.so, even for QT5 builds).

QT4 output: 
ET_DYN libvlccore.so.8,librt.so.1,libidn.so.11,libpthread.so.0,libdl.so.2,libdbus-1.so.3,libQtGui.so.4,libQtCore.so.4,libX11.so.6,libstdc++.so.6,libm.so.6,libc.so.6,libgcc_s.so.1 /usr/lib/vlc/plugins/gui/libqt4_plugin.so

QT5 output: 
ET_DYN libvlccore.so.8,librt.so.1,libidn.so.11,libpthread.so.0,libdl.so.2,libdbus-1.so.3,libQt5Widgets.so.5,libXi.so.6,libQt5X11Extras.so.5,libQt5Gui.so.5,libQt5Core.so.5,libX11.so.6,libstdc++.so.6,libm.so.6,libc.so.6,libgcc_s.so.1 /usr/lib/vlc/plugins/gui/libqt4_plugin.so

[Comment 5 Nick Andrade 2016-02-08 08:17:20 UTC]

Created attachment 424876 [details, diff]
vlc-2.2.2-qt5widgets.patch

The referenced new patch (see previous comment).

[Comment 6 Nick Andrade 2016-02-08 08:19:06 UTC]

Jeremey / Jouni (and anyone else interested), please test the attachments over the next few days, and if by mid-week no major bugs have been found, I'll work with the proxy-maint team to get it added to portage.

[Comment 7 Jeremy Murphy 2016-02-08 09:53:46 UTC]

Thanks, Nick, I'll get right on it. Really appreciate your quick response.

And my apologies to NP-Hardass (lol, great name), I will show restraint in future.

[Comment 8 Jeremy Murphy 2016-02-08 10:09:56 UTC]

Initial tests are positive: emerges cleanly, runs, plays audio.

[Comment 9 Jeremy Murphy 2016-02-08 10:11:58 UTC]

This is on a Plasma 5 desktop, using Qt 5.5.1, btw.

[Comment 10 Jouni Kosonen 2016-02-08 10:29:50 UTC]

(In reply to Jeremy Murphy from comment #9)
> This is on a Plasma 5 desktop, using Qt 5.5.1, btw.

Also works on KDE4 + Qt 5.5.1 and has a fully functional full screen mode. 
Looks good.

I think repoman would complain about the ebuild copyright year, though.

I've modified PR 811 to match and it passes checks.

[Comment 11 Nick Andrade 2016-02-08 21:58:21 UTC]

Thanks for testing and for catching the copyright year.  For the record, I'm testing under qt4 in MATE (and so far so good).  Please continue to try use cases and if we're on track, I'll shoot for ~ release on Weds.

[Comment 12 Miroslav Šulc 2016-02-09 10:02:44 UTC]

for me compilation failed (configure phase):

configure: error: "You cannot build VLC with Qt-5.5.0. You need to backport I78ef29975181ee22429c9bd4b11d96d9e68b7a9c"


[ebuild     U  ] media-video/vlc-2.2.2:0/5-8::gentoo [2.2.1-r1:0/5-8::gentoo] USE="X a52 alsa avcodec avformat cdda dbus dvb dvbpsi dvd encode ffmpeg flac gcrypt jack jpeg libass libnotify libsamplerate matroska modplug mp3 mpeg mtp musepack ncurses ogg opengl opus png pulseaudio qt5 samba speex svg swscale taglib theora truetype vaapi vdpau vorbis vpx x264 x265 xcb xml xv -aalib (-altivec) -atmo (-audioqueue) -bidi -bluray -cddb -chromaprint -dc1394 -debug -directfb (-directx) -dts (-dxva2) -faad -fdk -fluidsynth -fontconfig -gme -gnome -gnutls -growl -httpd -ieee1394 -kate -kde -libav -libcaca -libtar -libtiger -linsys -lirc -live -lua (-macosx-dialog-provider) (-macosx-eyetv) (-macosx-qtkit) (-macosx-quartztext) (-media-library) (-neon) -omxil -opencv -optimisememory -postproc -projectm -qt4 -rdp -rtsp -run-as-root -schroedinger -sdl -sdl-image -sftp -shout -sid -skins {-test} -tremor -twolame -udev -upnp -v4l -vcdx -vlm -vnc -wma-fixed -zeroconf -zvbi" CPU_FLAGS_X86="mmx sse" 0 KiB


i am on ~amd64 and i have dev-qt/qtwidgets-5.5.1-r1 installed. if you need more info, just let me know what you need.

[Comment 13 Jouni Kosonen 2016-02-09 12:06:03 UTC]

It looks like the version bump went into the tree already without the qt5 patch.

[Comment 14 Account removed 2016-02-09 12:15:05 UTC]

hi,
I used this tiny configure patch via epatch_user (googled, not mine) and this "fixes" comment #9
http://pastebin.com/HEhty0RV

[Comment 15 Account removed 2016-02-09 12:15:48 UTC]

heh, comment #12 even...

[Comment 16 Nick Andrade 2016-02-09 16:57:32 UTC]

Created attachment 425084 [details]
vlc-2.2.2.ebuild

Updating the copyright date (includes all previous changes already mentioned).

[Comment 17 Nick Andrade 2016-02-09 16:59:59 UTC]

(In reply to Jouni Kosonen from comment #13)
> It looks like the version bump went into the tree already without the qt5
> patch.

A developer put in a different version (presumably without looking at this bug).  I've replied to a bug related to that, and this ebuild should be in portage quickly.

[Comment 18 Lars Wendler (Polynomial-C) (RETIRED) 2016-02-09 19:55:49 UTC]

commit fe5dc79e3f08966ed5dedeffbce7446995351b8f
Author: Lars Wendler <[e-mail]>
Date:   Tue Feb 9 20:50:52 2016

    media-video/vlc: Fixed compilation with qt5 (bug #574256).

    Patch provided by Nick Andrade in bug #574064

    Package-Manager: portage-2.2.27
    Signed-off-by: Lars Wendler <[e-mail]>

commit 76316f1b39de5f0923a62c5e8c0e83cb1efa69a8
Author: Lars Wendler <[e-mail]>
Date:   Tue Feb 9 08:41:18 2016

    media-video/vlc: Removed old.

    Package-Manager: portage-2.2.27
    Signed-off-by: Lars Wendler <[e-mail]>

commit fce413c87208a0690ad78d7289a02de313ddbca5
Author: Lars Wendler <[e-mail]>
Date:   Tue Feb 9 08:29:04 2016

    media-video/vlc: Bump to version 2.2.2

    Package-Manager: portage-2.2.27
    Signed-off-by: Lars Wendler <[e-mail]>




Hi Nick,

sorry that I simply igonred your work here. I was so keen on getting vlc-2.2.2 with EAPI-6 into portage that I didn't look for a bump request bug in the first place.
I've taken your patch and added it into portage.
I promise to not ignore your work again in the future. Thanks for taking care of vlc. If you want some vlc commit being done in the future, simply CC me to the corresponding vlc bugs.

[Comment 19 Nick Andrade 2016-02-09 21:09:12 UTC]

Hi Lars, no worries, I appreciate the enthusiasm for VLC, thanks!

[Comment 20 Arfrever Frehtes Taifersar Arahesis 2016-02-10 16:31:04 UTC]

(In reply to Lars Wendler (Polynomial-C) from comment #18)
> commit fce413c87208a0690ad78d7289a02de313ddbca5
> Author: Lars Wendler <[e-mail]>
> Date:   Tue Feb 9 08:29:04 2016
> 
>     media-video/vlc: Bump to version 2.2.2
> 
>     Package-Manager: portage-2.2.27
>     Signed-off-by: Lars Wendler <[e-mail]>

You forgot to apply these changes in vlc-2.2.9999.ebuild and vlc-9999.ebuild.

[Comment 21 Lars Wendler (Polynomial-C) (RETIRED) 2016-02-10 16:55:08 UTC]

(In reply to Arfrever Frehtes Taifersar Arahesis from comment #20)
> (In reply to Lars Wendler (Polynomial-C) from comment #18)
> > commit fce413c87208a0690ad78d7289a02de313ddbca5
> > Author: Lars Wendler <[e-mail]>
> > Date:   Tue Feb 9 08:29:04 2016
> > 
> >     media-video/vlc: Bump to version 2.2.2
> > 
> >     Package-Manager: portage-2.2.27
> >     Signed-off-by: Lars Wendler <[e-mail]>
> 
> You forgot to apply these changes in vlc-2.2.9999.ebuild and vlc-9999.ebuild.

Feel free to send patches.