Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 573502 - app-admin/conky-1.10.1: patch to build with wifi support
Summary: app-admin/conky-1.10.1: patch to build with wifi support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Daniel Pielmeier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-31 15:11 UTC by Stanislav Nikitin
Modified: 2016-02-19 16:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
conky-1.10.1-includewlan.patch (conky-1.10.1-includewlan.patch,478 bytes, patch)
2016-01-31 15:11 UTC, Stanislav Nikitin
Details | Diff
patch v2 as provided in git (conky-1.10.1-includewlan.patch,527 bytes, patch)
2016-02-19 16:40 UTC, Till Schäfer
Details | Diff
CMakeError log with patch v2 (CMakeError.log,6.87 KB, text/x-log)
2016-02-19 16:42 UTC, Till Schäfer
Details
CMakeOutput.log with patch v2 (CMakeOutput.log,69.81 KB, text/x-log)
2016-02-19 16:43 UTC, Till Schäfer
Details
build log with patch v2 (build.log,7.88 KB, text/x-log)
2016-02-19 16:43 UTC, Till Schäfer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Stanislav Nikitin 2016-01-31 15:11:47 UTC
Created attachment 424322 [details, diff]
conky-1.10.1-includewlan.patch

Despite on fixes in git before 1.10.1 release, there is still a cmake_check_file call on line 141, which is used only if "wifi" USE flag is activated. Attached patch fixing this problem.
Comment 1 Daniel Pielmeier gentoo-dev 2016-02-01 19:41:01 UTC
There have been updates regarding this fix. Shouldn't the fix go like this?

https://github.com/brndnmtthws/conky/commit/ce08b9fe7b20454870a4aae20b442da24ce51dcd
Comment 2 Stanislav Nikitin 2016-02-02 10:48:20 UTC
Probably... It just compiles if I apply this patch.
Comment 3 Stanislav Nikitin 2016-02-02 10:48:44 UTC
I mean my patch, of course :).
Comment 4 Daniel Pielmeier gentoo-dev 2016-02-03 19:34:24 UTC
(In reply to Stanislav Nikitin from comment #2)
> Probably... It just compiles if I apply this patch.

Do you mind testing the patch from the link I provided.
Comment 5 Till Schäfer 2016-02-19 16:37:48 UTC
conky still fails with the patch  conky-1.10.1-includewlan.patch attached to this bug report because some parts inside iwlib.h are not found. 

When using the referenced version, the check went through. 

However, conky still fails to build because the program "man" was not found: 

CMake Error at cmake/ConkyPlatformChecks.cmake:403 (message):
  Unable to find program 'man'
Call Stack (most recent call first):
  CMakeLists.txt:37 (include)


Looking at the CMake log, this still seems to be a problem related to wifi: 

Determining if the function iw_sockets_open exists failed with the following output:
Change Dir: /var/tmp/portage/app-admin/conky-1.10.1/work/conky-1.10.1_build/CMakeFiles/CMakeTmp

Run Build Command:"/usr/bin/gmake" "cmTC_e78f2/fast"
/usr/bin/gmake -f CMakeFiles/cmTC_e78f2.dir/build.make CMakeFiles/cmTC_e78f2.dir/build
gmake[1]: Entering directory '/var/tmp/portage/app-admin/conky-1.10.1/work/conky-1.10.1_build/CMakeFiles/CMakeTmp'
Building C object CMakeFiles/cmTC_e78f2.dir/CheckFunctionExists.c.o
/usr/bin/x86_64-pc-linux-gnu-gcc  -D_GNU_SOURCE   -DNDEBUG -std=c99 -O2 -pipe -march=native -ggdb  -DCHECK_FUNCTION_EXISTS=iw_sockets_open   -o CMakeFiles/cmTC_e78f2.dir/CheckFunctionExists.c.o -c /usr/share/cmake/Modules/CheckFunctionExists.c
Linking C executable cmTC_e78f2
/usr/bin/cmake -E cmake_link_script CMakeFiles/cmTC_e78f2.dir/link.txt --verbose=1
/usr/bin/x86_64-pc-linux-gnu-gcc  -std=c99 -O2 -pipe -march=native -ggdb  -DCHECK_FUNCTION_EXISTS=iw_sockets_open   -Wl,-O1 -Wl,--as-needed  CMakeFiles/cmTC_e78f2.dir/CheckFunctionExists.c.o  -o cmTC_e78f2 -rdynamic 
CMakeFiles/cmTC_e78f2.dir/CheckFunctionExists.c.o: In function `main':
/usr/share/cmake/Modules/CheckFunctionExists.c:11: undefined reference to `iw_sockets_open'
collect2: error: ld returned 1 exit status
CMakeFiles/cmTC_e78f2.dir/build.make:97: recipe for target 'cmTC_e78f2' failed
gmake[1]: *** [cmTC_e78f2] Error 1
gmake[1]: Leaving directory '/var/tmp/portage/app-admin/conky-1.10.1/work/conky-1.10.1_build/CMakeFiles/CMakeTmp'
Makefile:126: recipe for target 'cmTC_e78f2/fast' failed
gmake: *** [cmTC_e78f2/fast] Error 2


please find the complete log output attached
Comment 6 Till Schäfer 2016-02-19 16:40:31 UTC
Created attachment 425916 [details, diff]
patch v2 as provided in git

https://github.com/brndnmtthws/conky/commit/ce08b9fe7b20454870a4aae20b442da24ce51dcd
Comment 7 Till Schäfer 2016-02-19 16:42:16 UTC
Created attachment 425918 [details]
CMakeError log with patch v2
Comment 8 Till Schäfer 2016-02-19 16:43:22 UTC
Created attachment 425920 [details]
CMakeOutput.log with patch v2
Comment 9 Till Schäfer 2016-02-19 16:43:58 UTC
Created attachment 425922 [details]
build log with patch v2
Comment 10 Till Schäfer 2016-02-19 16:55:12 UTC
a little deeper look and the man error seems to have a different cause. 

Should i open a seperate bug report for this or should be just rename this bug to app-admin/conky-1.10.1 fails to build?
Comment 11 Daniel Pielmeier gentoo-dev 2016-02-19 16:59:14 UTC
(In reply to Till Schäfer from comment #10)
> a little deeper look and the man error seems to have a different cause. 
> 
> Should i open a seperate bug report for this or should be just rename this
> bug to app-admin/conky-1.10.1 fails to build?

Thanks for testing the patch. I already fixed this in git.

Regarding the issue about not finding man, this is already bug #486270.