Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 572522 - app-emulation/wine-9999 - does not verify if the staging patchset is compatible with the wine repo
Summary: app-emulation/wine-9999 - does not verify if the staging patchset is compatib...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-21 13:36 UTC by Nico (Keridos)
Modified: 2016-01-30 05:34 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
wine-9999.ebuild patch (file_572522.txt,1.23 KB, patch)
2016-01-29 06:00 UTC, Nico (Keridos)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nico (Keridos) 2016-01-21 13:36:55 UTC
Currently the 9999 ebuild does not verify if the staging patchset is compatible with the wine repo. The patchinstaller has an option "--upstream-commit" which prints out the SHA1 hash of the upstream commit. Using that we can checkout the correct git commit for wine to successfully apply the staging patches. I have a little hacked ebuild that works for me locally but as I made some more changes I would not like to put up a patch for that, tbh.

Reproducible: Sometimes

Steps to Reproduce:
1.emerge wine-9999 when wine repo is not the version staging repo was rebased against.
2.
3.
Comment 1 Adam Feldman gentoo-dev 2016-01-22 11:56:23 UTC
Patches welcome as this isn't high on my to-do list. It's also not critical as staging usually only lags by a hour or so when they do break upstream compatibility.
Comment 2 Nico (Keridos) 2016-01-29 06:00:52 UTC
Created attachment 424130 [details, diff]
wine-9999.ebuild patch

Needs a small rework for the patches section, see the FIXME there.
Comment 3 Nico (Keridos) 2016-01-29 06:01:53 UTC
Rebased my local overlay to the current ebuild and uploaded the diff here. Note the FIXME, those file were not in my local overlay thus building failed.
Comment 4 Adam Feldman gentoo-dev 2016-01-30 01:06:55 UTC
(In reply to Nico (Keridos) from comment #2)
> Created attachment 424130 [details, diff] [details, diff]
> wine-9999.ebuild patch
> 
> Needs a small rework for the patches section, see the FIXME there.

Calling git directly is highly undesirable, the git-r3 eclass should be utilized.  Also, the actions involving git manipulating the sources should happen in the src_unpack phase.
Comment 5 Adam Feldman gentoo-dev 2016-01-30 05:34:26 UTC
Fixed in 4469bdbf74cebf43c949f218a202caf0f5b70f99