Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 57238 - patch ppp-2.4.2-r2 doesn't terminate with the updetach option
Summary: patch ppp-2.4.2-r2 doesn't terminate with the updetach option
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 All
: Highest minor (vote)
Assignee: Gentoo Dialup Developers
URL:
Whiteboard:
Keywords:
: 51889 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-07-15 16:22 UTC by Thomas G
Modified: 2004-09-24 13:26 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
control_c.patch (control_c.patch,402 bytes, patch)
2004-07-15 16:22 UTC, Thomas G
Details | Diff
ppp-2.4.2-r2.ebuild (ppp-2.4.2-r2.ebuild,5.24 KB, text/plain)
2004-07-15 16:26 UTC, Thomas G
Details

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Thomas G 2004-07-15 16:22:58 UTC
Created attachment 35514 [details, diff]
control_c.patch
Comment 2 Thomas G 2004-07-15 16:26:09 UTC
Created attachment 35515 [details]
ppp-2.4.2-r2.ebuild
Comment 3 Axel Dyks 2004-07-23 14:00:04 UTC
Obviously a duplicate of #51889.
We just proposed the same patch there... :-)

I added agriffis and lanius to CC:
Hope that the don't get annoyed but all these mails.

Axel

P.S.: Maybe the owner of this bug (Thomas) should increase priority.
Comment 4 Thomas G 2004-07-25 04:55:08 UTC
ack
Comment 5 Heinrich Wendel (RETIRED) gentoo-dev 2004-08-02 01:27:42 UTC
*** Bug 51889 has been marked as a duplicate of this bug. ***
Comment 6 Daniel Black (RETIRED) gentoo-dev 2004-09-23 17:25:07 UTC
Fixed in ppp-2.4.2-r3.ebuild
Comment 7 Axel Dyks 2004-09-24 13:26:14 UTC
Thanks for adding the <<control_c.patch>>
Terminating <<pppd>> with signal 15 (TERM) now works as expected.

But... because shutting down the ppp-connection may take some
time (about 3 seconds on my gentoo box, while a PPTP/VPN-
connection to a watchguard firebox is active),
I do not think that sending subsequent signals to the
ppp-process is a good idea.

As I have already proposed <<net.ppp0 stop>> should just
wait a little longer, i. e.

  <<kill ${PID}>> 

in the while loop [ ${COUNT} -lt 10 ] should be subsituted by

  <<ewarn "Waiting for ${IFACE} to go down...">>

or something similar.

This modification results to the following output, when
shutting down the ppp-connection (and take about 3 seconds) 
 * Bringing ppp0 down...
 * Waiting for ppp0 to go down...
 * Waiting for ppp0 to go down...     [ ok ]

The unmodified version results to the following output
(and takes the full 10 seconds)
 * Bringing ppp0 down...
 * Error stopping pppd                [ !! ]
                                      [ ok ]

Also with the unmodified version the final result is
  1. the <<<ppp link>> is down and
  2. the <<net.ppp0 service>> is stopped
... but with the cost of some extra seconds
and an unneccessary error message.

If I'm the only one that is affected, forget about this comment.
If not, then "-r3" should be updated by changing the corresponding
line in <<files/2.4.2/net.ppp0>>
 
Greets

Axel (XL)