Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 571142 - Ebuild for media-video/handbrake does not properly display einfo
Summary: Ebuild for media-video/handbrake does not properly display einfo
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Ian Whyman (thev00d00) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-07 08:13 UTC by tragbbbet
Modified: 2016-05-22 11:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tragbbbet 2016-01-07 08:13:39 UTC
After emerging this package, the ebuild is written to display einfo to inform the user of how to execute both the cli and the gui versions of the application, however due to a bug, these messages are not displayed. This is particularly disconcerting when building with USE=gtk, because the resulting executable file name (ghb) is entirely impossible to guess, and can only be found using utilities like qlist, which the user might not be advanced enough to know how to use. I suppose it is a testament to the tech-savviness of almost all Gentoo users that this bug seems to have gone unreported until now.
Comment 1 Mart Raudsepp gentoo-dev 2016-01-09 07:05:35 UTC
The ebuild has double pkg_postinst, the other for gnome2_icon_cache_update. Can't have multiple of those like this, the latter overrides the former and the einfo one isn't called at all. These must be merged into one.
Seems to be a bug from before git repo went git already.

handbrake[gtk] does install a .desktop file, so ghb should be discoverable from desktop environment application menus just fine.

As a side note from the GNOME side, USE=gtk mentioned the Gimp ToolKit +, it hasn't really been associated with that since gtk2 times, please consider revising that USE flag. I do approve of there being a more detailed description in local metadata than the generic USE=gtk from use.desc, however.
Maybe something like "Enable a <pkg>x11-libs/gtk+</pkg> based GUI for HandBrake" or something; though then it actually becomes rather similar to generic use.desc, hmm... :D
On the topic of metadata, might also be good to describe what practical benefits or additions USE=gstreamer gives to users - and how it compares to the other additional support flags if aac and h265 encoding support might come from USE=gstreamer too (does it?).
Comment 2 Ian Whyman (thev00d00) (RETIRED) gentoo-dev 2016-05-22 11:28:54 UTC
Thanks for reporting!

This is sorted in the tree.