Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 570922 - dev-vcs/mercurial: punt $HG env.d entry
Summary: dev-vcs/mercurial: punt $HG env.d entry
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Development (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Dirkjan Ochtman (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-01-04 23:47 UTC by SpanKY
Modified: 2016-05-13 11:05 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2016-01-04 23:47:26 UTC
the ebuild started installing an env.d entry that sets HG a while back:
https://sources.gentoo.org/dev-util/mercurial/mercurial-1.0.1-r1.ebuild?r1=1.1&r2=1.2

the reason was:
Install env.d file containing HG variable needed for hgk.

imo, hgk should be fixed to falling back to finding `hg` via $PATH.  otherwise, we stuff this variable into the environment of pretty much every process out there.

the hg python code already does this:
mercurial/util.py:
def hgexecutable():
    """return location of the 'hg' executable.

    Defaults to $HG or 'hg' in the search path.
    """
Comment 1 Dirkjan Ochtman (RETIRED) gentoo-dev 2016-05-13 11:05:34 UTC
I've added a mercurial-3.8.1-r1 that no longer installs the env.d file. From inspecting the Mercurial source code, it seems that HG is now always set when invoking hgk, at least when it is invoked through the hgk extension (the hg view command).