Bug 570092 – =app-backup/duplicity-0.6.23-r1 build failure with librsync-2

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Richard Freeman 2015-12-29 12:41:06 UTC]

Created attachment 421076 [details]
build log

The current stable version of duplicity fails to build with librsync-2.0.0, which is being stabilized due to a security issue.

building 'duplicity._librsync' extension
creating /var/tmp/portage/app-backup/duplicity-0.6.23-r1/work/duplicity-0.6.23-python2_7/temp.linux-x86_64-2.7
creating /var/tmp/portage/app-backup/duplicity-0.6.23-r1/work/duplicity-0.6.23-python2_7/temp.linux-x86_64-2.7/duplicity
x86_64-pc-linux-gnu-gcc -march=amdfam10 -Os -pipe -frename-registers -fweb -freorder-blocks -freorder-blocks-and-partiti
on -funit-at-a-time -ftree-pre -fgcse-sm -fgcse-las -fgcse-after-reload -fmerge-all-constants -ftree-vectorize -ftree-pa
rallelize-loops=4 -mabm -msse4a -fstack-protector -fPIC -I/usr/include/python2.7 -c duplicity/_librsyncmodule.c -o /var/
tmp/portage/app-backup/duplicity-0.6.23-r1/work/duplicity-0.6.23-python2_7/temp.linux-x86_64-2.7/duplicity/_librsyncmodu
le.o
duplicity/_librsyncmodule.c: In function ‘_librsync_new_sigmaker’:
duplicity/_librsyncmodule.c:71:38: error: ‘RS_DEFAULT_STRONG_LEN’ undeclared (first use in this function)
                              (size_t)RS_DEFAULT_STRONG_LEN);
                                      ^
duplicity/_librsyncmodule.c:71:38: note: each undeclared identifier is reported only once for each function it appears in
duplicity/_librsyncmodule.c:70:17: error: too few arguments to function ‘rs_sig_begin’
   sm->sig_job = rs_sig_begin((size_t)blocklen,
                 ^
In file included from duplicity/_librsyncmodule.c:26:0:
/usr/include/librsync.h:370:11: note: declared here
 rs_job_t *rs_sig_begin(size_t new_block_len,
           ^
error: command 'x86_64-pc-linux-gnu-gcc' failed with exit status 1

[Comment 1 Richard Freeman 2015-12-29 12:41:31 UTC]

Created attachment 421078 [details]
emerge --info

[Comment 2 Richard Freeman 2015-12-29 12:42:00 UTC]

Created attachment 421080 [details]
emerge -pqv '=app-backup/duplicity-0.6.23-r1::gentoo'

[Comment 3 Richard Freeman 2015-12-29 13:04:05 UTC]

It appears that this is no longer an issue in =app-backup/duplicity-0.6.26.  Is there any reason this shouldn't be stabilized?  I'm starting to test it now.

[Comment 4 Richard Freeman 2015-12-30 12:08:14 UTC]

I did a reasonably complex backup/restore test and I'm pretty confident that this can be safely stabilized.

Any objections to doing so?

[Comment 5 Richard Freeman 2015-12-31 14:56:51 UTC]

amd64 stable

I'm going to go ahead and co-maintain this since radhermit is away, and this is a security issue.

Arch teams, please stabilize:
=app-backup/duplicity-0.6.26

[Comment 6 Agostino Sarubbo 2016-01-05 08:41:03 UTC]

x86 stable

[Comment 7 Agostino Sarubbo 2016-01-05 08:41:26 UTC]

ppc stable. Closing.