Bug 569530 – games-board/freedoko fails to build with libsigc++-2.6

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Pacho Ramos 2015-12-23 19:56:46 UTC]

Even appending append-cxxflags -std=c++11

it fails because of it relying on old headers:
In file included from players.cpp:34:0:
player.h:39:27: fatal error: sigc++/object.h: No such file or directory
 #include <sigc++/object.h>
                           ^
compilation terminated.
../../Makefile.rules:83: recipe for target 'players.o' failed
make[2]: *** [players.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory '/var/tmp/portage/games-board/freedoko-0.7.13/work/FreeDoko_0.7.13/src/ui/gtkmm'
../Makefile.rules:96: recipe for target 'gtkmm' failed
make[1]: *** [gtkmm] Error 2
make[1]: Leaving directory '/var/tmp/portage/games-board/freedoko-0.7.13/work/FreeDoko_0.7.13/src/ui'
Makefile.rules:96: recipe for target 'ui' failed
make: *** [ui] Error 2
make: Leaving directory '/var/tmp/portage/games-board/freedoko-0.7.13/work/FreeDoko_0.7.13/src'

[Comment 1 Pacho Ramos 2015-12-25 17:36:27 UTC]

Removing the sigc++/object.h usage should be enough

[Comment 2 Pacho Ramos 2015-12-31 11:42:25 UTC]

[master 91ecddb] games-board/freedoko: Fix building with latest glibmm/libsigc++ (#569530)
 2 files changed, 136 insertions(+)
 create mode 100644 games-board/freedoko/files/freedoko-0.7.13-libsigc26.patch
 create mode 100644 games-board/freedoko/freedoko-0.7.13-r1.ebuild

[Comment 3 Mr. Bones. (RETIRED) 2015-12-31 20:24:10 UTC]

--- src/player/ai/heuristics.cpp        2015-11-17 14:04:13.267766289 +0100
+++ src/player/ai/heuristics.cpp        2015-11-17 14:04:13.267766289 +0100
@@ -2350,7 +2350,7 @@
            && (   card.less(c)
                || (   tpoints >= hi.value( Aiconfig::LIMITDOLLE )
                    && c.less(Card(Card::DIAMOND, Card::QUEEN))
-                   && !hi.color_runs( t.startcard().color() ) < 1
+                   && (hi.color_runs( t.startcard().color() ) > 0)
                    && !t.islastcard()
                   )
               )

What's this change about?  It seems unrelated to the libsigc++ changes.

[Comment 4 Pacho Ramos 2015-12-31 21:24:09 UTC]

I inheritted it from:
https://aur.archlinux.org/packages/freedoko/

But it looks like, indeed, the package builds and runs ok without that change, then, it could be dropped indeed :/

Do you want me to revbump dropping that part of the patch?

[Comment 5 Mr. Bones. (RETIRED) 2015-12-31 21:38:38 UTC]

nah, it's fine.  I was just curious.