Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 568000 - app-text/poppler—add qt4-cairo-backend patches to enable subpixel rendering
Summary: app-text/poppler—add qt4-cairo-backend patches to enable subpixel rendering
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Maciej Mrozowski
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-11 16:14 UTC by cristiano04
Modified: 2023-12-20 07:45 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description cristiano04 2015-12-11 16:14:53 UTC
It would be amazing if we could patch the supported versions with the respective USE flags for vastly superior font rendering, akin (although still inferior) to the one achieved by Acrobat's CoolType library.

https://github.com/giddie/poppler-qt4-cairo-backend

Reproducible: Always
Comment 1 Maciej Mrozowski gentoo-dev 2016-01-09 03:44:25 UTC
Interesting idea and nice rendered fonts. Patches however make source deviate quite a bit from upstream, making future revbumps tricky. if anything it could be added behind some masked USE flag. (needs to be masked as we don't guarantee that it actually always builds and maintaining patch compatibility in Gentoo would be a chore).
Comment 2 cristiano04 2016-01-09 08:35:42 UTC
(In reply to Maciej Mrozowski from comment #1)
> Interesting idea and nice rendered fonts. Patches however make source
> deviate quite a bit from upstream, making future revbumps tricky. if
> anything it could be added behind some masked USE flag. (needs to be masked
> as we don't guarantee that it actually always builds and maintaining patch
> compatibility in Gentoo would be a chore).

That would be very nice and I whole heartedly agree with your approach.
Comment 3 cristiano04 2016-01-09 08:37:07 UTC
Although it would be nice to always have the latest officially supported version (0.37 in this case) in the tree.
Comment 4 Paul Gideon Dann 2016-02-08 09:33:14 UTC
Hi there, I'm the author of the poppler-qt4-cairo patchset. Just wanted to let you know that there have been very few occasions where I needed to make code changes to the patchset since I created it. From version to version, generally only an soname in a CMakeLists file is affected.

I respond to out-of-date notifications on the ArchLinux AUR (https://aur.archlinux.org/packages/poppler-qt-lcd/), and of course you can always create an issue on the Github repository.

The only issue you may encounter is that I only made the necessary modifications to the CMake build system. If you need support for autotools, I imagine it should be an easy fix for someone familiar with the build system. I'd gratefully receive a patch or pull request for this :p
Comment 5 Paul Gideon Dann 2016-02-08 09:37:25 UTC
Oh, in fact the soname bump doesn't even affect the standard patchset. I'm thinking of an additional patch I use in the ArchLinux AUR PKGBUILD to enable building of the qt4 backend without building the whole poppler library.
Comment 6 cristiano04 2016-03-21 16:45:43 UTC
Any news on this?
Comment 7 Maciej Mrozowski gentoo-dev 2016-03-22 23:45:24 UTC
Ok, let's try this. cairo-qt USE flag added, masked by default.
I needed to rebase qt4-lcd branch manually on top of upstream 0.42 release to make patchset apply cleanly.
I didn't notice any particular kerning improvements in sample .pdf file I checked, output is just a bit less blurry though (sometimes to the point of being slightly jagged using system-default font antialiasing settings - disabled? with antialiasing explicitly enabled in System Settings, differences between Splash and Cairo are even smaller).
As long as patches apply, I can keep them in tree I guess...
Comment 8 cristiano04 2016-03-23 16:36:40 UTC
It looks better, but with excessive fringing, as a result of the Cairo backend using FT_LCD_FILTER_LEGACY as opposed to FT_LCD_FILTER_DEFAULT.
Comment 9 cristiano04 2016-03-25 11:03:15 UTC
(In reply to Maciej Mrozowski from comment #7)
> Ok, let's try this. cairo-qt USE flag added, masked by default.
> I needed to rebase qt4-lcd branch manually on top of upstream 0.42 release
> to make patchset apply cleanly.
> I didn't notice any particular kerning improvements in sample .pdf file I
> checked, output is just a bit less blurry though (sometimes to the point of
> being slightly jagged using system-default font antialiasing settings -
> disabled? with antialiasing explicitly enabled in System Settings,
> differences between Splash and Cairo are even smaller).
> As long as patches apply, I can keep them in tree I guess...

If you want better font rendering you'll need to patch your Cairo as well. I know you're not the Cairo maintainer, I'm just letting you know on the basis of achieving the best possible font rendering.

Patch: https://github.com/CrisBRM/fontconfig-ultimate/commit/b6c84fcd9822cb42b0b1593970288dd8e222e06a
Comment 10 Maciej Mrozowski gentoo-dev 2016-05-28 01:30:52 UTC
@Alexander
What do you think? Fancy adding that patch behind some masked USE flag?