Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 567798 - net-dns/avahi: don't install automatic dbus launch
Summary: net-dns/avahi: don't install automatic dbus launch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-12-08 21:04 UTC by Jonas Jelten
Modified: 2016-02-12 01:13 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Jelten 2015-12-08 21:04:30 UTC
/usr/lib/systemd/system/dbus-org.freedesktop.Avahi.service is installed by the avahi package.

/etc/dbus-1/system.d/avahi-dbus.conf defines, that the above service is used to start /usr/share/dbus-1/system-services/org.freedesktop.Avahi.service, which in turn starts the systemd-service.

This all happens without any user interaction which is why my synergy, someday pulled in avahi unnoticed, which was then started automatically and I was humiliated by my friends for having a running avahi.

Please let the user explicitly has to enable the service via systemctl, so that it can't automatically be started just via dbus after (maybe unwanted) installation.

Reproducible: Always
Comment 1 Mike Gilbert gentoo-dev 2015-12-08 21:19:07 UTC
Pacho: This seems to be your doing.

I would recommend reverting 80f3f8ce6f234b51254947dc0f579fe843972961.

You can add a postinst message advising people to enable it if they want.
Comment 2 Anthony Basile gentoo-dev 2015-12-08 21:32:03 UTC
(In reply to Mike Gilbert from comment #1)
> Pacho: This seems to be your doing.
> 
> I would recommend reverting 80f3f8ce6f234b51254947dc0f579fe843972961.
> 
> You can add a postinst message advising people to enable it if they want.

let's try to post patches for review rather that directly committing except for trivial stuff.  i'd like to keep a abreast of what's happening with avahi.
Comment 3 Mike Gilbert gentoo-dev 2015-12-08 23:12:54 UTC
(In reply to Anthony Basile from comment #2)

My suggestion would be to simply remove the symlink creation from src_install. Bug 537000 should probably have been a WONTFIX or INVALID.
Comment 4 Anthony Basile gentoo-dev 2015-12-09 12:39:14 UTC
(In reply to Mike Gilbert from comment #3)
> (In reply to Anthony Basile from comment #2)
> 
> My suggestion would be to simply remove the symlink creation from
> src_install. Bug 537000 should probably have been a WONTFIX or INVALID.

Not so simple because some ebuilds are now stabilized.  I added -r11 to the tree dropping the sym link and dropping everything to ~arch.  I'll wait about a week or so for testing and then autostabilize all the arches since this is a trivial change.

@systemd folks, please test to make sure this is what you want.
Comment 5 Mike Gilbert gentoo-dev 2015-12-09 21:51:25 UTC
I would really like Pacho's feedback as the one who made the change in the first place.

I'm approaching this as a systemd user who doesn't use avahi; he may have another perspective.
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2015-12-09 21:58:20 UTC
I agree with Jonas here. Avahi is a network service, and I would rather not have those started automagically without explicit 'on' switch just because something pulled libavahi in. Not sure if running avahi could actually cause any security issues but it discloses information you may not wish to disclose.

And I'm systemd user who actually uses avahi.
Comment 7 Pacho Ramos gentoo-dev 2015-12-12 09:52:09 UTC
(In reply to Anthony Basile from comment #2)
> (In reply to Mike Gilbert from comment #1)
> > Pacho: This seems to be your doing.
> > 
> > I would recommend reverting 80f3f8ce6f234b51254947dc0f579fe843972961.
> > 
> > You can add a postinst message advising people to enable it if they want.
> 
> let's try to post patches for review rather that directly committing except
> for trivial stuff.  i'd like to keep a abreast of what's happening with
> avahi.

I waited for months for any reply in bug 537000
Comment 8 Pacho Ramos gentoo-dev 2015-12-12 09:55:45 UTC
I reported it to upstream when avahi was "revived" and we are a bit lost about how systemd people are expecting us to deal with that stupid situation in that systemd silently fails to start avahi when needed (for example, every time I try to print something from GTK+ dialogs, it tries to load zeroconf exported printers and you will see that they are not shown for some "unknown reason" until you see in journal logs the systemd errors of it trying to start avahi and failing):
https://github.com/lathiat/avahi/issues/29

If anyone wants to help there, please do :)
Comment 9 Anthony Basile gentoo-dev 2015-12-12 12:05:12 UTC
(In reply to Pacho Ramos from comment #7)
> (In reply to Anthony Basile from comment #2)
> > (In reply to Mike Gilbert from comment #1)
> > > Pacho: This seems to be your doing.
> > > 
> > > I would recommend reverting 80f3f8ce6f234b51254947dc0f579fe843972961.
> > > 
> > > You can add a postinst message advising people to enable it if they want.
> > 
> > let's try to post patches for review rather that directly committing except
> > for trivial stuff.  i'd like to keep a abreast of what's happening with
> > avahi.
> 
> I waited for months for any reply in bug 537000

The bug simply quotes the Arch Linux "fix" without any proposed course of action.  I cannot fix/test systemd bugs.
Comment 10 Mike Gilbert gentoo-dev 2015-12-12 14:36:33 UTC
What is the behavior of avahi when NOT running systemd? Does it get auto-started in response to a dbus request?
Comment 11 Anthony Basile gentoo-dev 2015-12-14 09:32:48 UTC
(In reply to Mike Gilbert from comment #10)
> What is the behavior of avahi when NOT running systemd? Does it get
> auto-started in response to a dbus request?

it does not
Comment 12 Anthony Basile gentoo-dev 2016-02-12 01:13:23 UTC
(In reply to Mike Gilbert from comment #3)
> (In reply to Anthony Basile from comment #2)
> 
> My suggestion would be to simply remove the symlink creation from
> src_install. Bug 537000 should probably have been a WONTFIX or INVALID.

since the symlink creation has been reverted, this bug should be fixed