Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 567040 - Paludis can't handle depstring in media-video/vlc ebuild
Summary: Paludis can't handle depstring in media-video/vlc ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal minor (vote)
Assignee: Nick Andrade
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-11-28 17:10 UTC by hololeap
Modified: 2015-12-20 05:42 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
vlc-2.2.1-r1.ebuild (vlc-2.2.1-r1.ebuild,15.58 KB, text/plain)
2015-12-15 06:41 UTC, Nick Andrade
Details

Note You need to log in before you can comment on or make changes to this bug.
Description hololeap 2015-11-28 17:10:53 UTC
Paludis is having a hard time with the line:

samba? ( || ( >=net-fs/samba-3.4.6:0[smbclient] >=net-fs/samba-4.0.0:0[client] ) )

The problem is the open-ended constraint on the first spec. Paludis is matching any samba-4.* version to this first constraint, but then fails when it checks the USE flag (since "smbclient" has been renamed to "client"). A workaround that works with Paludis is as follows:

samba? ( || ( ( >=net-fs/samba-3.4.6:0[smbclient] <net-fs/samba-4.0.0_alpha1:0[smbclient] ) >=net-fs/samba-4.0.0_alpha1:0[client] ) )

Just setting an upper limit on that first spec makes the definition a little clearer and helps Paludis understand it.

Reproducible: Always
Comment 1 Nick Andrade 2015-12-14 05:29:00 UTC
Thanks for reporting this, will test the proposed fix and most likely will incorporate it.
Comment 2 Nick Andrade 2015-12-15 06:35:31 UTC
The proposed USE works as expected.  On a
Comment 3 Nick Andrade 2015-12-15 06:36:48 UTC
The proposed USE constraint works as expected, and on a positive note, VLC 2.2.1 seems to be building cleanly with GCC 5.3 which just entered ~amd64.
Comment 4 Nick Andrade 2015-12-15 06:41:52 UTC
Created attachment 419250 [details]
vlc-2.2.1-r1.ebuild

Updated ebuild attached. As the proxy-maintainer for VLC, I'm good with this change.  No need to revbump from my perspective.  If a Gentoo dev stumbles upon this bug, please feel free to implement, otherwise I'll try to get a dev from #gentoo-proxy-maint to make the change this week.

Thanks for reporting this bug; I don't use paludis so it never impacted me.
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2015-12-20 05:42:05 UTC
commit 4e4c506ea085fc9b4a04f6d9f06468030a6dd12b
Author: Ian Delaney <idella4@gentoo.org>
Date:   Thu Dec 17 22:46:04 2015 +0800

    media-video/vlc: correct dep string to cater to paludis
    
    fix proposed by Will S, endorsed by proxy maintainer via gentoo bug
    
    Gentoo bug: #567040