texmaker 4.5 was released on October 29th, 2015. Reproducible: Always
Created attachment 417830 [details] ebuild Please test.
Created attachment 417834 [details, diff] unbundles myspell dicts Please test.
I see that I failed to include/specify the filenames for the ebuild and patches :) sorry about that. Those would be "ebuild": texmaker-4.5.ebuild "unbundles myspell dicts": texmaker-4.5-unbundle.patch
Comment on attachment 417830 [details] ebuild >PATCHES=( > "${FILESDIR}"/${P}-unbundle.patch > ) > Why did you drop the other patch?
Do you like to send a PR on GH or should I merge from here?
(In reply to Justin Lecher from comment #4) > Comment on attachment 417830 [details] > ebuild > > >PATCHES=( > > "${FILESDIR}"/${P}-unbundle.patch > > ) > > > > Why did you drop the other patch? It doesn't appear to be necessary anymore (I was unable to find the lines to which it referred in the 4.5 sources).
(In reply to Justin Lecher from comment #5) > Do you like to send a PR on GH or should I merge from here? I have a github account but have never done a PR. I have this in my testing overlay, it's not a clone of the main tree. Can I still do this via github, or would it be easier to have you merge it?
(In reply to Stephen Bosch from comment #6) > (In reply to Justin Lecher from comment #4) > > Comment on attachment 417830 [details] > > ebuild > > > > >PATCHES=( > > > "${FILESDIR}"/${P}-unbundle.patch > > > ) > > > > > > > Why did you drop the other patch? > > It doesn't appear to be necessary anymore (I was unable to find the lines to > which it referred in the 4.5 sources). The corresponding code isn't changes. And the patch still applies, which is always a good sign that it is needed.
(In reply to Stephen Bosch from comment #7) > (In reply to Justin Lecher from comment #5) > > Do you like to send a PR on GH or should I merge from here? > > I have a github account but have never done a PR. I have this in my testing > overlay, it's not a clone of the main tree. Can I still do this via github, > or would it be easier to have you merge it? Your benefit is that you are listed as the author of the commit in the git history. * Clone the GH repo * copy you changes in * commit and push * send PR
(In reply to Justin Lecher from comment #8) > (In reply to Stephen Bosch from comment #6) > > (In reply to Justin Lecher from comment #4) > > > Comment on attachment 417830 [details] > > > ebuild > > > > > > >PATCHES=( > > > > "${FILESDIR}"/${P}-unbundle.patch > > > > ) > > > > > > > > > > Why did you drop the other patch? > > > > It doesn't appear to be necessary anymore (I was unable to find the lines to > > which it referred in the 4.5 sources). > > The corresponding code isn't changes. And the patch still applies, which is > always a good sign that it is needed. Whoops -- really? When I tried it, it failed to apply. Perhaps I made a mistake somewhere.
(In reply to Justin Lecher from comment #9) > (In reply to Stephen Bosch from comment #7) > > (In reply to Justin Lecher from comment #5) > > > Do you like to send a PR on GH or should I merge from here? > > > > I have a github account but have never done a PR. I have this in my testing > > overlay, it's not a clone of the main tree. Can I still do this via github, > > or would it be easier to have you merge it? > > Your benefit is that you are listed as the author of the commit in the git > history. > > * Clone the GH repo > * copy you changes in > * commit and push > * send PR Ok, I can do this. Which repo do I clone? (I've done some work with the sci overlay but never the main tree)
Can I create a branch from the main tree that is already existing on my system and push that?
Never mind, I will figure it out :)
Ok, changes pushed and PR created. (For future reference: it's not sufficient to clone the GH repo, it needs to be forked first :) )
It appears that spell-check is not working in 4.5. Since I adapted the spell-check patch from the 4.4.1 ebuild (for which spell-check was still working), this seems like a likely cause. Still, I don't know why it isn't working. Should I file a new bug?
Please ignore my last comment. After multiple restarts, spell-check is now working again. Very strange.
commit 2a05793c844039179977d07120140d32d41471dd Author: Stephen Bosch <stephen.bosch@gmail.com> Date: Thu Nov 26 12:38:16 2015 +0100 app-office/texmaker: make qt5 default https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2a05793c844039179977d07120140d32d41471dd commit 428abb3121094fd558a371b66eb8d68ae7cd38b0 Author: Stephen Bosch <stephen.bosch@gmail.com> Date: Thu Nov 26 12:26:00 2015 +0100 app-office/texmaker: version bump to 4.5 #566790 https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=428abb3121094fd558a371b66eb8d68ae7cd38b0
