Title says it all :)
Needs to be 4.2.1 (4.2.0 had a few nagging bugs). From a packagers point of view we need to bump icu to 56; otherwise no build-related changes.
works with icu-55 but has runtime issues / bugs with >=dev-libs/libuv-1.7.0
Please keyword ppc (and ppc64) as well. It has been supported for a few releases, even 4.1.1 can be built for ppc
(In reply to Joakim Tjernlund from comment #3) > Please keyword ppc (and ppc64) as well. > It has been supported for a few releases, even 4.1.1 can be built for ppc Sure but you need to CC the right arch teams in for them to keyword this package.
commit 98e0982 (HEAD, origin/master, origin/HEAD, master) Author: Patrice Clement <monsieurp@gentoo.org> Date: Fri Oct 23 04:12:29 2015 -0700 net-libs/nodejs: Keyword for ppc+ppc64. Disable tests on both platforms. Fixes bug 562984. Package-Manager: portage-2.2.20.1
Had to revert this commit. It was missing several steps and adding others not needed.
(In reply to Patrice Clement from comment #5) > commit 98e0982 (HEAD, origin/master, origin/HEAD, master) > Author: Patrice Clement <monsieurp@gentoo.org> > Date: Fri Oct 23 04:12:29 2015 -0700 > > net-libs/nodejs: Keyword for ppc+ppc64. Disable tests on both platforms. > Fixes bug 562984. > > Package-Manager: portage-2.2.20.1 I'm utterly confused about this bug: 1) the bug is for a bump to 4.2.1. Stick to that as the issue. 2) Regarding comment 3. Totally reasonable request but for another bug report. 3) Don't ask the users to cc arch teams. Devs do it because the users don't know when a package is ready for keywording/stabilization or not, the maintainer does. Also the maintainer here Patrick Lauer so he should be making that call. Its not that critical for keywording, but for stabilization that's the maintainer's call because he should be familiar with the package's state. 4) You added the restrictions on the test for ppc/ppc64 but this doesn't make sense because its not keyworded there, and even if it were, how do you know the tests fail? did you test on ppc/ppc64. (In reply to Joakim Tjernlund from comment #3) > Please keyword ppc (and ppc64) as well. > It has been supported for a few releases, even 4.1.1 can be built for ppc Please open a bug requesting this. Do you want just ppc or ppc64 as well?
I did try to compile nodejs on timberdoodle and the compilation went through (I had to modify the ebuild a bit as you might have noticed). However, I ran the tests and ended up with a ton of errors spat out all over my terminal. I decided to go ahead and keyword it anyway. Sorry for the noise, commit has since been reverted by Ian so proceed as you deem best. (In reply to Anthony Basile from comment #7) > (In reply to Patrice Clement from comment #5) > > commit 98e0982 (HEAD, origin/master, origin/HEAD, master) > > Author: Patrice Clement <monsieurp@gentoo.org> > > Date: Fri Oct 23 04:12:29 2015 -0700 > > > > net-libs/nodejs: Keyword for ppc+ppc64. Disable tests on both platforms. > > Fixes bug 562984. > > > > Package-Manager: portage-2.2.20.1 > > I'm utterly confused about this bug: > > 1) the bug is for a bump to 4.2.1. Stick to that as the issue. > > 2) Regarding comment 3. Totally reasonable request but for another bug > report. > > 3) Don't ask the users to cc arch teams. Devs do it because the users don't > know when a package is ready for keywording/stabilization or not, the > maintainer does. Also the maintainer here Patrick Lauer so he should be > making that call. Its not that critical for keywording, but for > stabilization that's the maintainer's call because he should be familiar > with the package's state. > > 4) You added the restrictions on the test for ppc/ppc64 but this doesn't > make sense because its not keyworded there, and even if it were, how do you > know the tests fail? did you test on ppc/ppc64. > > > > (In reply to Joakim Tjernlund from comment #3) > > Please keyword ppc (and ppc64) as well. > > It has been supported for a few releases, even 4.1.1 can be built for ppc > > Please open a bug requesting this. Do you want just ppc or ppc64 as well?
4.2.2 in tree.
