Bug 562046 – =net-libs/miniupnpc-1.9.20150917-r1 breaks compile of =games-strategy/megaglest-3.11.1: error: too few arguments to function ‘UPNPDev* upnpDiscover()

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Torsten Kaiser 2015-10-02 15:33:10 UTC]

Created attachment 413506 [details]
build.log from failed compile

The core problem like Bug 562020: miniupnp has added a new parameter to this function and programs using this API break.

From #562020:
Commit that added the API: https://github.com/miniupnp/miniupnp/commit/1da63faa4fff5cb30e5d4b848ceef80a292382b9

Error in case of megaglest:

/var/tmp/portage/games-strategy/megaglest-3.11.1/work/megaglest-3.11.1/source/shared_lib/sources/platform/posix/socket.cpp: In static member function ‘static int Shared::Platform::UPNP_Tools::upnp_init(void*)’:
/var/tmp/portage/games-strategy/megaglest-3.11.1/work/megaglest-3.11.1/source/shared_lib/sources/platform/posix/socket.cpp:2569:113: error: invalid conversion from ‘int*’ to ‘unsigned char’ [-fpermissive]  
   devlist = upnpDiscover(upnp_delay, upnp_multicastif, upnp_minissdpdsock, upnp_sameport, upnp_ipv6, &upnp_error);
                                                                                                                 ^
/var/tmp/portage/games-strategy/megaglest-3.11.1/work/megaglest-3.11.1/source/shared_lib/sources/platform/posix/socket.cpp:2569:113: error: too few arguments to function ‘UPNPDev* upnpDiscover(int, const char*, const char*, int, int, unsigned char, int*)’
In file included from /var/tmp/portage/games-strategy/megaglest-3.11.1/work/megaglest-3.11.1/source/shared_lib/sources/platform/posix/socket.cpp:58:0:
/usr/include/miniupnpc/miniupnpc.h:54:1: note: declared here
 upnpDiscover(int delay, const char * multicastif,

[Comment 1 Sander Sweers 2015-10-02 16:59:19 UTC]

Created attachment 413546 [details, diff]
Add miniupnpc api 14 support

Totally untested but should work

[Comment 2 Jouni Rinne 2015-10-04 16:43:42 UTC]

Yep. The patch works. Any chances to have this included in the official build?

[Comment 3 Mr. Bones. (RETIRED) 2015-10-05 00:47:54 UTC]

in portage.   thanks for the bug report and patch.