Requesting update or upgrade of current net-libs/nodejs. Currently the ebuild is at version 0.12.7 and the current release is at 4.0.0 with major changes and bug fixes since 0.12.7. It would be most appreciated if this could be updated. Thank you for all your hard work on this distribution. Reproducible: Always
Since io.js and node.js have merged, forming the latest nodejs-4.0.0 release, we should probably do a package move on net-libs/iojs -> net-libs/nodejs as well. Fortunately the version numbers make it clear what's happening.
Created attachment 412086 [details] net-libs/nodejs-4.0.0.ebuild while i am no ebuild maker, here is a first crack at a nodejs-4.0.0 ebuild gleaned+copied from existing nodejs+iojs ebuilds. working well on ~x64 GNU+Linux thus far. corrections/comments/etc. please.
Hey, few thoughts: - merging iojs/node: I'd suggest against it. We (upstream) will continue to support iojs for a bit longer. My suggestion is to revisit in 6 months. - need to bump the icu dependency to 55 since that's been done upstream. - switch to .tar.xz tarball I haven't had a chance to diff against iojs, but my preferred path here would be using iojs as a baseline then remove the bundled-libs stuff.
Created attachment 412168 [details] net-libs/nodejs-4.0.0.ebuild updated ebuild: - ICU dependency now dev-libs/icu:0/55 - switch to .tar.xz tarball
(In reply to Johan Bergström from comment #3) > Hey, > few thoughts: thanks for the feedback and maintaining the {node,io}js ebuilds in the first place. > - merging iojs/node: I'd suggest against it. We (upstream) will continue to > support iojs for a bit longer. My suggestion is to revisit in 6 months. not sure what you mean here (again, i am an ebuild newbie): unless i did something really wrong i figured the original iojs ebuilds would still be available even with this nodejs-4.0.0 ebuild. is that not the case? otherwise i apologize for not following you. > - need to bump the icu dependency to 55 since that's been done upstream. added "icu? ( dev-libs/icu:0/55 )" BTW: where did you find the exact dependencies and versions upstream? i did not see anything so specific. > - switch to .tar.xz tarball i assume .XZ is preferred? > > I haven't had a chance to diff against iojs, but my preferred path here > would be using iojs as a baseline then remove the bundled-libs stuff. again, i am prob not following you, but i simply started w/ your iojs-3.0.0 ebuild and changed a few things to match the specific differences from the nodejs-0.12.7 ebuild. to me that seems like i started with iojs as a baseline? also, i did not see any bundled-libs stuff in the iojs-3.0.0 ebuild so i assume that is already gone? OK, i updated+emerged the net-libs/nodejs-4.0.0.ebuild attachment. comments/etc, thanks again.
v4.1.0 is current: https://github.com/nodejs/node/blob/v4.1.0/CHANGELOG.md
(In reply to Wayne DePrince Jr. from comment #5) > (In reply to Johan Bergström from comment #3) > > Hey, > > few thoughts: > > thanks for the feedback and maintaining the {node,io}js ebuilds in the > first place. I use it pretty adamantly as well, so win-win :) > > > - merging iojs/node: I'd suggest against it. We (upstream) will continue to > > support iojs for a bit longer. My suggestion is to revisit in 6 months. > > not sure what you mean here (again, i am an ebuild newbie): unless i did > something really wrong i figured the original iojs ebuilds would still be > available even with this nodejs-4.0.0 ebuild. is that not the case? > otherwise i apologize for not following you. Was referring to another comment about dropping iojs from tree which I would personally suggest against for now. > > > - need to bump the icu dependency to 55 since that's been done upstream. > > added "icu? ( dev-libs/icu:0/55 )" > > BTW: where did you find the exact dependencies and versions upstream? i > did not see anything so specific. Since I'm part of upstream and work with deps I know whats coming in and going out. The simplest way to quickly get a grasp would be looking at https://github.com/nodejs/node/tree/master/deps > > > - switch to .tar.xz tarball > > i assume .XZ is preferred? Yeah, it saves us users ~30% bandwidth. Always opt for size. > > > > > I haven't had a chance to diff against iojs, but my preferred path here > > would be using iojs as a baseline then remove the bundled-libs stuff. > > again, i am prob not following you, but i simply started w/ your > iojs-3.0.0 ebuild and changed a few things to match the specific differences > from the nodejs-0.12.7 ebuild. to me that seems like i started with iojs as > a baseline? also, i did not see any bundled-libs stuff in the iojs-3.0.0 > ebuild so i assume that is already gone? My point was just that if you want my final LGTM/suggest for includsion I just need to do some more legwork. > > OK, i updated+emerged the net-libs/nodejs-4.0.0.ebuild attachment. > comments/etc, thanks again. Thanks for the update
Thanks for everyone's work and time. Please note nodejs v4.1.1 is the current stable version now. Can we upgrade the ebuild to that and then how long till it gets in portage generally? I know I can put it in an overlay, etc. Again thanks for everyone's time and work.
Created attachment 412838 [details] net-libs/nodejs-4.1.1.ebuild https://github.com/nodejs/node/blob/v4.1.1/CHANGELOG.md
(In reply to Wayne DePrince Jr. from comment #9) > Created attachment 412838 [details] > net-libs/nodejs-4.1.1.ebuild > > https://github.com/nodejs/node/blob/v4.1.1/CHANGELOG.md Thanks, I've added it to git: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6c7457fd3a251bb8253aa9325c8e96d4e5ac8452 (In reply to Johan Bergström from comment #7) > My point was just that if you want my final LGTM/suggest for includsion I > just need to do some more legwork. Note that I've removed more failing tests. Note that the test-stdout-close-unref.js failure is probably due to emerge/portage redirecting stdin from /dev/null. You can probably reproduce it outside of emerge if you also redirect stdin from /dev/null like this: test.py < /dev/null
(In reply to Zac Medico from comment #10) > Thanks, I've added it to git: > > https://gitweb.gentoo.org/repo/gentoo.git/commit/ > ?id=6c7457fd3a251bb8253aa9325c8e96d4e5ac8452 > thank you!
