Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 558900 - sci-mathematics/rstudio-0.99.473 needs a patch for QT5
Summary: sci-mathematics/rstudio-0.99.473 needs a patch for QT5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mark Wright
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-27 10:51 UTC by Helmut Jarausch
Modified: 2015-08-30 14:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for QT5 (QDataStream.patch,405 bytes, patch)
2015-08-27 10:51 UTC, Helmut Jarausch
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Helmut Jarausch 2015-08-27 10:51:17 UTC
Created attachment 410400 [details, diff]
patch for QT5

sci-mathematics/rstudio-0.99.473 needs the attached patch to compile with QT5.
Furthermore it looks like it builds with clang-3.6.2-r100 just fine.
Comment 1 Mark Wright gentoo-dev 2015-08-28 13:22:47 UTC
Thanks for reporting. It built fine for me with dev-qt/qtcore-5.4.2.
I guess I'm curious what the compiler error was in the build.log.
The patch looks harmless though, I'll try it and check it still builds for me.
Comment 2 Franz Trischberger 2015-08-29 10:15:51 UTC
Wouldn't it be better to patch out the bundled qtsingleapplication? AFAIK that was done for several other applications already.
Comment 3 Mark Wright gentoo-dev 2015-08-30 14:33:21 UTC
(In reply to Franz Fellner from comment #2)
> Wouldn't it be better to patch out the bundled qtsingleapplication? AFAIK
> that was done for several other applications already.

Yes, thanks for the suggestion.

commit 7a45c4dcb255f80d2bc7c891f532bc81a95ecaa8
Author: Mark Wright <gienah@gentoo.org>
Date:   Mon Aug 31 00:28:31 2015 +1000

    sci-mathematics/rstudio: Fix bug 558900, unbundle qtsingleapplication
    
    Thanks to Helmut Jarausch for reporting, Franz Fellner for suggesting patching
    rstudio to use dev-qt/qtsingleapplication[qt5] rather than the bundled version.
    Remove sys-devel/clang upper bound, thanks to Helmut Jarausch for reporting and
    testing with clang-3.6.2-r100. I tested it builds with clang-3.7.0_rc3.
    Fix bug 558988 sci-mathematics/rstudio-0.99.473 missing qt dependencies,
    thanks to Oleg and Anthony Staines for reporting and testing.