Bug 558344 – app-emulation/docker 1.7.1 -> 1.8.2 with dev-lang/go-1.5 fails to build - gopath/src/github.com/docker/docker/pkg/devicemapper/devmapper_wrapper.go:191: Cdeps.device undefined (type *C.struct_dm_deps has no field or method device)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ivan Iraci 2015-08-21 11:24:09 UTC]

Because of changes in Go lang within version 1.5, docker-1.7.1 doesn't build:
---> Making bundle: dynbinary (in bundles/1.7.1/dynbinary)
Created binary: bundles/1.7.1/dynbinary/dockerinit-1.7.1
Building: bundles/1.7.1/dynbinary/docker-1.7.1
# github.com/docker/docker/pkg/devicemapper
.gopath/src/github.com/docker/docker/pkg/devicemapper/devmapper_wrapper.go:191: Cdeps.device undefined (type *C.struct_dm_deps has no field or method device)
 * ERROR: app-emulation/docker-1.7.1::gentoo failed (compile phase):
 *   dynbinary failed

The problem has been fixed upstream:
https://github.com/rhatdan/docker/commit/0a426878b52e9eaa243df117ece0608804c28d29

If you put the patch provided with this ticket in /etc/portage/patches/app-emulation/docker-1.7.1 docker will emerge successfully.

Reproducible: Always

Steps to Reproduce:
1. emerge docker
2. kaboom
Actual Results:  
---> Making bundle: dynbinary (in bundles/1.7.1/dynbinary)
Created binary: bundles/1.7.1/dynbinary/dockerinit-1.7.1
Building: bundles/1.7.1/dynbinary/docker-1.7.1
# github.com/docker/docker/pkg/devicemapper
.gopath/src/github.com/docker/docker/pkg/devicemapper/devmapper_wrapper.go:191: Cdeps.device undefined (type *C.struct_dm_deps has no field or method device)
 * ERROR: app-emulation/docker-1.7.1::gentoo failed (compile phase):
 *   dynbinary failed

Expected Results:  
Docker should build fine.

[Comment 1 Ivan Iraci 2015-08-21 11:25:09 UTC]

Created attachment 409748 [details, diff]
Patch that fixes docker for go lang versions 1.4 and 1.5.

[Comment 2 Greg Turner 2015-08-22 11:50:45 UTC]

W4M.

[Comment 3 Greg Turner 2015-08-22 11:51:39 UTC]

(In reply to Ivan Iraci from comment #1)
> Created attachment 409748 [details, diff] [details, diff]
> Patch that fixes docker for go lang versions 1.4 and 1.5.

to be clear, Ivan's patch is what W4M -- not what's in portage.

[Comment 4 Søren Dalby Larsen 2015-08-24 11:33:10 UTC]

I can confirm problem and patch W4M as well.

[Comment 5 Tianon 2015-08-25 21:52:45 UTC]

https://github.com/docker/docker/pull/15404 is the official upstream fix for this issue (which is now merged, and I think changed slightly from the patch that's attached here already)

[Comment 6 Ivan Iraci 2015-08-26 12:50:56 UTC]

Same problem with docker-1.8.1.

"My" patch (now in /etc/portage/patches/app-emulation/docker-1.8.1) still fixes this issue.

[Comment 7 Ivan Iraci 2015-08-26 12:57:20 UTC]

(In reply to Tianon from comment #5)

> https://github.com/docker/docker/pull/15404 is the official upstream fix for
> this issue (which is now merged, and I think changed slightly from the patch
> that's attached here already)

The patch attached to this ticket *is* the official upstream fix.
You can compare the diffs bit by bit and you will notice no difference at all. :)

[Comment 8 Dennis Schridde 2015-08-26 16:09:25 UTC]

(In reply to Tianon from comment #5)
> https://github.com/docker/docker/pull/15404 is the official upstream fix for
> this issue (which is now merged, and I think changed slightly from the patch
> that's attached here already)

This patch didn't make it into any release (tag), yet. Is it possible to include it in the ebuild until a release including a fix is available?

[Comment 9 Kacper Kowalik (Xarthisius) (RETIRED) 2015-08-27 15:43:18 UTC]

Successfully rebased and updated refs/heads/master.
xarth@shakuras /cvs/gentoo/app-emulation/docker $ repoman full
commit ebf518399f1b302b738d6da9afa0351f4035384a
Author: Kacper Kowalik <[e-mail]>
Date:   Thu Aug 27 10:42:07 2015 -0500

    Apply upstream patch fixing issue with go>=1.4. Fixes #558344

[Comment 10 Ivan Iraci 2015-09-29 07:54:03 UTC]

Same problem with docker-1.8.2, same fix.

[Comment 11 Justin Lecher (RETIRED) 2015-09-29 08:35:08 UTC]

commit 50de2aa9b73b3670bbb2a0a8cfa9f6168c1f1f88
Author: Justin Lecher <[e-mail]>
Date:   Tue Sep 29 10:20:29 2015 +0200
    
    app-emulation/docker: Apply compat patch for go-1.5
    
    Gentoo-Bug: https://bugs.gentoo.org/show_bug.cgi?id=558344
    
    Package-Manager: portage-2.2.22
    Signed-off-by: Justin Lecher <[e-mail]>
    
    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=50de2aa9b73b3670bbb2a0a8cfa9f6168c1f1f88

[Comment 12 Brian Evans (RETIRED) 2015-12-30 15:08:52 UTC]

*** Bug 570146 has been marked as a duplicate of this bug. ***