Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 557954 - app-emulation/spice-vdagent-0.16.0 does not install systemd units with USE="systemd"
Summary: app-emulation/spice-vdagent-0.16.0 does not install systemd units with USE="s...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tiziano Müller (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-16 19:00 UTC by Chris Mayo
Modified: 2015-08-22 19:26 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Mayo 2015-08-16 19:00:22 UTC 
$ qlist spice-vdagent
/usr/sbin/spice-vdagentd
/usr/share/gdm/autostart/LoginWindow/spice-vdagent.desktop
/usr/share/gdm/greeter/autostart/spice-vdagent.desktop
/usr/share/man/man1/spice-vdagentd.1.bz2
/usr/share/man/man1/spice-vdagent.1.bz2
/usr/share/doc/spice-vdagent-0.16.0/TODO.bz2
/usr/share/doc/spice-vdagent-0.16.0/NEWS.bz2
/usr/share/doc/spice-vdagent-0.16.0/ChangeLog.bz2
/usr/share/doc/spice-vdagent-0.16.0/README.RHEL-5.bz2
/usr/share/doc/spice-vdagent-0.16.0/README.bz2
/usr/bin/spice-vdagent
/var/log/spice-vdagentd/.keep_app-emulation_spice-vdagent-0
/etc/xdg/autostart/spice-vdagent.desktop
/etc/init.d/spice-vdagent
/etc/conf.d/spice-vdagent


Ebuild fixed for me by changing:

 src_configure() {
 	local opt="--with-session-info=none --with-init-script=systemd"
 
-	use systemd && opt="--with-session-info=systemd"
-	use consolekit && opt="${opt} --with-session-info=console-kit"
+	use systemd && opt+=" --with-session-info=systemd"
+	use consolekit && opt+=" --with-session-info=console-kit"
 
 	econf \
 		--localstatedir=/var \
Comment 1 Chris Mayo 2015-08-16 19:02:27 UTC 
That's assuming systemd and consolekit are really exclusive. As they are not maybe = is better than +=.
Comment 2 Matthias Maier gentoo-dev 2015-08-22 19:26:23 UTC 
commit 024f47dd77aeb73c7f756e72a62da748dde17309
Author: Matthias Maier <tamiko@gentoo.org>
Date:   Sat Aug 22 14:25:21 2015 -0500

    app-emulation/spice-vdagent: install unit file with USE=systemd (bug #557954)
    
    Fix a typo that prevented installation of the systemd unit file in case of
    USE=systemd
    
    Bug: 557954
    
    Package-Manager: portage-2.2.20.1

diff --git a/app-emulation/spice-vdagent/spice-vdagent-0.16.0.ebuild b/app-emulation/spice-vdagent/spice-vdagent-0.16.0.ebuild
index b652156..932365f 100644
--- a/app-emulation/spice-vdagent/spice-vdagent-0.16.0.ebuild
+++ b/app-emulation/spice-vdagent/spice-vdagent-0.16.0.ebuild
@@ -36,8 +36,8 @@ ERROR_VIRTIO_CONSOLE="VirtIO console/serial device support is required"
 src_configure() {
        local opt="--with-session-info=none --with-init-script=systemd"
 
-       use systemd && opt="--with-session-info=systemd"
-       use consolekit && opt="${opt} --with-session-info=console-kit"
+       use systemd && opt+=" --with-session-info=systemd"
+       use consolekit && opt+=" --with-session-info=console-kit"
 
        econf \
                --localstatedir=/var \