Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 557154 - sys-devel/llvm-9999: "Invalid value for CMAKE_BUILD_TYPE: Gentoo"
Summary: sys-devel/llvm-9999: "Invalid value for CMAKE_BUILD_TYPE: Gentoo"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-09 17:03 UTC by Bigos
Modified: 2015-08-24 15:30 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
A patch that fixes the build (0005-cmake-Dont-restrict-CMAKE_BUILD_TYPE.patch,605 bytes, patch)
2015-08-09 17:05 UTC, Bigos 		Details | Diff
Equivalent patch against 624a11dc4f96e2ab9b8ca230fd230e2de69ffe48 (0005-cmake-Dont-restrict-CMAKE_BUILD_TYPE.patch,835 bytes, patch)
2015-08-11 05:33 UTC, Robin Kauffman 		Details | Diff
Updated patch (build-type.patch,563 bytes, patch)
2015-08-12 19:13 UTC, egon2003 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Bigos 2015-08-09 17:03:31 UTC 
The upstream llvm has started to restrict the CMAKE_BUILD_TYPE variable value. Since Gentoo uses a custom build type (Gentoo) it no longer configures properly.

Reproducible: Always
Comment 1 Bigos 2015-08-09 17:05:36 UTC 
Created attachment 408652 [details, diff]
A patch that fixes the build

Attached is a patch that disables this behaviour altogether. I think such a resolution of this problem is the best, since this restriction doesn't bring anything to the portage build system.
Comment 2 Robin Kauffman 2015-08-11 05:33:07 UTC 
Created attachment 408774 [details, diff]
Equivalent patch against 624a11dc4f96e2ab9b8ca230fd230e2de69ffe48
Comment 3 Robin Kauffman 2015-08-11 15:57:47 UTC 
Commit 8179d06019a28c0e9febedf349864c918467ebca has been reverted by ece40fd6d5a7a2422305d0dba4af814fe6e2e9b6; Bigos' patch is now authoritative again.
Comment 4 Robin Kauffman 2015-08-11 22:15:58 UTC 
Commit e7e85970eb416ae6b07e09229ca44a16b204b017 re-applied 8179d06019a28c0e9febedf349864c918467ebca.  Above patch now works better :-/.  Aaaaaaa.
Comment 5 egon2003 2015-08-12 19:13:34 UTC 
Created attachment 408886 [details, diff]
Updated patch

The above patches does not apply anymore. Attaching updated patch.
Comment 6 darkbasic 2015-08-13 09:02:28 UTC 
Why don't you upstream it in Gentoo?
Comment 7 Konstantin M 2015-08-15 23:59:23 UTC 
Hm, I'm not sure about all consequences, but I made the build work by using "CMAKE_BUILD_TYPE=Release" (which I put before "cmake-utils_src_configure" in the ebuild). At least mesa built afterwards. Is there a benefit in using a custom build type ?
Comment 8 Bigos 2015-08-16 17:04:12 UTC 
The benefit of custom build type is that it will then use make.conf variables (like CFLAGS). Without it, the CMake build system will use its defaults (like "-O2 -DNDEBUG" for Release, IIRC).
Comment 9 Bernard Cafarelli gentoo-dev 2015-08-24 15:30:34 UTC 
Thanks everyone

Not sure how this will evolve, but in the meantime I added the patch that strips this check.