Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 557124 - net-analyzer/munin is missing dependency on dev-perl/CGI-Fast
Summary: net-analyzer/munin is missing dependency on dev-perl/CGI-Fast
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sysadmin Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-09 12:11 UTC by Justin Lecher (RETIRED)
Modified: 2015-08-12 11:18 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Lecher (RETIRED) gentoo-dev 2015-08-09 12:11:54 UTC
/usr/bin/spawn-fcgi -n -s /run/fastcgi-graph.sock-1 -P /run/spawn-fcgi/munin-cgi-graph-1.pid -u munin -g nginx -M 660 -- /usr/libexec/munin/cgi/munin-cgi-graph
Can't locate CGI/Fast.pm in @INC (you may need to install the CGI::Fast module) (@INC contains: /etc/perl /usr/local/lib64/perl5/5.22.0/x86_64-linux-thread-multi /usr/local/lib64/perl5/5.22.0 /usr/lib64/perl5/vendor_perl/5.22.0/x86_64-linux-thread-multi /usr/lib64/perl5/vendor_perl/5.22.0 /usr/lib64/perl5/5.22.0/x86_64-linux-thread-multi /usr/lib64/perl5/5.22.0) at /usr/libexec/munin/cgi/munin-cgi-graph line 36.
BEGIN failed--compilation aborted at /usr/libexec/munin/cgi/munin-cgi-graph line 36.

Please add missing dependency for cgi usage
Comment 1 Bernard Cafarelli gentoo-dev 2015-08-09 12:52:56 UTC
Side note: this should probably be a dependency only for >=perl-5.22, (stable) 5.20 has core CGI support (working fine with munin 2.0.25)
Comment 2 Justin Lecher (RETIRED) gentoo-dev 2015-08-11 06:45:00 UTC
@perl, could you please give advice?
Comment 3 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2015-08-11 07:02:38 UTC
I don't consider "FastCGI" and "CGI" the same thing really.

Having 'cgi' imply FastCGI is just weird.

However, the script "munin-cgi-graph" has an unconditional dependency on CGI::Fast.

Thus, anywhere that script is being even *installed*, the CGI::Fast dependency should also be.

And people who don't want CGI::Fast installed shouldn't get the bin script.

Grepping the source tree also indicates there is no dependency on FCGI.pm, even though the ebuild depends on it.

Though CGI-Fast depends on FCGI.

The extra confusion comes from the fact a CGI::Fast based code can be either run directly as CGI or FastCGI, ( but running it as CGI doesn't absolve it of the dependency requirements )

And CGI::Fast hard-requires FCGI.pm, regardless of whether or not you are using it in a FastCGI context.

===

Regardless of whether you want cgi support, or fastcgi, you need both FCGI and CGI::Fast installed.

Only if you want neither can you avoid those dependencies, *( and in such a case, the scripts requiring either should not be installed )
Comment 4 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2015-08-11 07:30:03 UTC
Other notes:

- Upstream appear to be nuking munin-cgi-graph entirely.

https://github.com/munin-monitoring/munin/tree/9faec2ef624e56b58b93ea3d022d4b6d56a98fcd

All the HTTP stuff is going into https://github.com/munin-monitoring/munin/blob/devel/script/munin-httpd  

Which uses  HTTP::Server::Simple::CGI

This will mean:

a) You can daemonize the script directly as an HTTP service
b) You can use the script like a CGI-bin somehow

As to how you will use that in future with FCGI if you desire it, that part is not clear at all.
Comment 5 Justin Lecher (RETIRED) gentoo-dev 2015-08-11 07:32:15 UTC
Thanks for the long explanation, but how can we solve the current situation? We are missing deps in the ebuild and the munin maintainers need to get a hint when and how to add dev-perl/CGI-Fast.
Comment 6 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev 2015-08-11 07:37:31 UTC
(In reply to Justin Lecher from comment #5)
> We are missing deps in the ebuild and the munin maintainers need to get a
> hint when and how to add dev-perl/CGI-Fast.

If you are installing munin-cgi-* , then my opinion is:

 always depend on dev-perl/CGI-Fast


If you don't do that, then you will simply be installing things that don't work, and you shouldn't do that.
Comment 7 Justin Lecher (RETIRED) gentoo-dev 2015-08-12 11:18:06 UTC
* commit 6dc75f1006ed62eeadc6916c52f9ff7dd13d4c78
* Author: Justin Lecher <jlec@gentoo.org>
* Date:   Wed Aug 12 13:17:09 2015 +0200
* 
*     net-analyzer/munin: Add missing dependency, bug #557124
*     
*     Package-Manager: portage-2.2.20.1
*     Signed-off-by: Justin Lecher <jlec@gentoo.org>