Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 555106 - sys-apps/rng-tools: man page reports incorrect default value for --rng-device
Summary: sys-apps/rng-tools: man page reports incorrect default value for --rng-device
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal trivial (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-16 20:14 UTC by Göktürk Yüksek
Modified: 2015-08-14 06:55 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Proposed fix for manpage (rng-tools-fix-manpage-default-random-device.patch,389 bytes, patch)
2015-07-16 22:27 UTC, Göktürk Yüksek 		Details | Diff
Patch for the ebuilds (rng-tools-ebuild-fixes.patch,907 bytes, patch)
2015-07-16 22:27 UTC, Göktürk Yüksek 		Details | Diff
Patch manpage inside ebuild with sed (rng-tools-5-manpage-hwrng-fix.patch,493 bytes, patch)
2015-07-21 15:57 UTC, Göktürk Yüksek 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Göktürk Yüksek archtester gentoo-dev 2015-07-16 20:14:14 UTC 
According to rngd man page the default value for the '--rng-device' option is '/dev/hwrandom'. However, in source code rngd_linux.c, it is hardcoded as '/dev/hwrng'. This is a minor issue as Gentoo init script will search for both. Nonetheless, man page is misleading.

Reproducible: Always




Fedora bugzilla entry for this bug: https://bugzilla.redhat.com/show_bug.cgi?id=1178871
Comment 1 Göktürk Yüksek archtester gentoo-dev 2015-07-16 22:27:36 UTC 
Created attachment 406940 [details, diff]
Proposed fix for manpage
Comment 2 Göktürk Yüksek archtester gentoo-dev 2015-07-16 22:27:58 UTC 
Created attachment 406942 [details, diff]
Patch for the ebuilds
Comment 3 Göktürk Yüksek archtester gentoo-dev 2015-07-21 15:57:46 UTC 
Created attachment 407352 [details, diff]
Patch manpage inside ebuild with sed

As per our discussion on #gentoo-proxy-maint with idella4, patching the manpage with sed is better than creating a separate patch file. It takes up less space than the patch file and easier to read when it's inside the ebuild. Note that this is only for rng-tools-5, although it should apply the same way to rng-tools-4 too. There is a stabilization bug open for rng-tools-5, so it makes sense to patch only rng-tools-5 and get rid of rng-tools-4 as soon as possible.