Bug 553346 – app-backup/deja-dup-34.0 fails to build

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Pacho Ramos 2015-06-26 17:20:23 UTC]

Created attachment 405802 [details]
build.log

I couldn't find any fix for this :S

[ 63%] /var/tmp/portage/app-backup/deja-dup-34.0/work/deja-dup-34.0/deja-dup/preferences/preferences-main.vala:49.24-49.36: error: The name `HeaderBar' does not exist in the context of `Gtk'
      var header = new Gtk.HeaderBar();
                       ^^^^^^^^^^^^^
/var/tmp/portage/app-backup/deja-dup-34.0/work/deja-dup-34.0/deja-dup/preferences/preferences-main.vala:49.11-49.38: error: var declaration not allowed with non-typed initializer
      var header = new Gtk.HeaderBar();
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/var/tmp/portage/app-backup/deja-dup-34.0/work/deja-dup-34.0/deja-dup/preferences/preferences-main.vala:50.7-50.12: error: The name `header' does not exist in the context of `PreferencesApp.activate'
      header.show_close_button = true;
      ^^^^^^
/var/tmp/portage/app-backup/deja-dup-34.0/work/deja-dup-34.0/deja-dup/preferences/preferences-main.vala:51.7-51.22: error: The name `set_titlebar' does not exist in the context of `Gtk.ApplicationWindow'
      dlg.set_titlebar(header);
      ^^^^^^^^^^^^^^^^
/var/tmp/portage/app-backup/deja-dup-34.0/work/deja-dup-34.0/deja-dup/preferences/preferences-main.vala:55.7-55.12: error: The name `header' does not exist in the context of `PreferencesApp.activate'
      header.pack_end(switcher);
      ^^^^^^
Compilation failed: 5 error(s), 0 warning(s)
deja-dup/preferences/CMakeFiles/deja-dup-preferences.dir/build.make:57: recipe for target 'deja-dup/preferences/preferences-main.c' failed

[Comment 1 Justin Lecher (RETIRED) 2015-06-26 17:37:12 UTC]

+  26 Jun 2015; Justin Lecher <[e-mail]> deja-dup-34.0.ebuild:
+  Raise min vala version, bug #553346
+

[Comment 2 Pacho Ramos 2015-06-27 09:21:43 UTC]

Created attachment 405836 [details]
build.log

I don't understand why 0.20 is still used even if I think the eclass is properly being used and 0.24 set as minimum :S

[Comment 3 Pacho Ramos 2015-06-27 09:21:57 UTC]

@gnome team, any thoughts? :/

[Comment 4 Pacho Ramos 2015-06-27 11:19:23 UTC]

Maybe it's because of the package using cmake and relying on cmake/FindVala.cmake for detection :|

[Comment 5 Pacho Ramos 2015-06-27 11:41:25 UTC]

I have failed to force a value for VALA_EXECUTABLE="${VALAC}" :@

[Comment 6 Alexandre Rostovtsev (RETIRED) 2015-06-27 16:55:57 UTC]

We just need to set -DVALA_EXECUTABLE="${VALAC}" in src_configure, otherwise it scans through a hard-coded list of ancient vala versions (most of which don't work with current deja-dup releases :)

Also, >=vala-0.22 should be fine, I don't see anything in deja-dup that really requires 0.24.

+  27 Jun 2015; Alexandre Rostovtsev <[e-mail]>
+  deja-dup-32.0-r1.ebuild, deja-dup-34.0.ebuild:
+  Build system uses VALA_EXECUTABLE cmake variable instead of VALAC env
+  variable (bug #553346, thanks to Pacho Ramos). Raise vala min version to
+  0.22, since 0.20 fails with >=gtk+-3.10.

[Comment 7 Pacho Ramos 2015-06-27 16:57:43 UTC]

Thanks a lot :), I am not used to cmake sadly :(

[Comment 8 Pacho Ramos 2015-06-27 17:00:59 UTC]

+  27 Jun 2015; Pacho Ramos <[e-mail]> deja-dup-34.0.ebuild:
+  Also looks to work fine with vala-0.28 (as other distributions are already
+  using via their unversioned 'valac' binary
+