Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 553334 - sys-auth/polkit-0.112-r2: general protection in libmozjs-17.0.so
Summary: sys-auth/polkit-0.112-r2: general protection in libmozjs-17.0.so
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Freedesktop bugs
URL: https://bugs.freedesktop.org/show_bug...
Whiteboard:
Keywords:
: 589998 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-06-26 13:43 UTC by Pacho Ramos
Modified: 2016-07-31 13:48 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Pacho Ramos gentoo-dev 2015-06-26 13:43:03 UTC
For a long time I am seeing this errors in dmesg... but I am not sure if the culprit is polkit or spidermonkey:17

[ 6553.454071] traps: polkitd[205] general protection ip:7f0e97497f12 sp:7ffdf79c0340 error:0 in libmozjs-17.0.so[7f0e97368000+2dc000]
[16092.282060] traps: polkitd[2815] general protection ip:7fa415620f12 sp:7ffdac805740 error:0 in libmozjs-17.0.so[7fa4154f1000+2dc000]
[25152.169186] traps: polkitd[6101] general protection ip:7fbd74d46f12 sp:7fffb7ef6770 error:0 in libmozjs-17.0.so[7fbd74c17000+2dc000]
[34092.954291] traps: polkitd[7334] general protection ip:7f48755e6f12 sp:7ffdf726c0e0 error:0 in libmozjs-17.0.so[7f48754b7000+2dc000]
[42552.727276] traps: polkitd[7813] general protection ip:7f905dcf1f12 sp:7ffddfdf5770 error:0 in libmozjs-17.0.so[7f905dbc2000+2dc000]
[70752.850343] traps: polkitd[8309] general protection ip:7f294f46af12 sp:7ffd47d5acc0 error:0 in libmozjs-17.0.so[7f294f33b000+2dc000]
[98892.509749] traps: polkitd[9929] general protection ip:7fb5c8525f12 sp:7fff9e85f4a0 error:0 in libmozjs-17.0.so[7fb5c83f6000+2dc000]

I am not sure if it could be related with:
https://bugs.freedesktop.org/show_bug.cgi?id=69501

Other option would be to move back to old spidermonkey slot to see if it works better... but looking to changelog looks like we would need to block :17 as, otherwise, it will be picked up automagically


Portage 2.2.18 (python 2.7.9-final-0, default/linux/amd64/13.0/desktop/gnome/systemd, gcc-4.8.4, glibc-2.20-r2, 4.0.5-gentoo x86_64)
=================================================================
System uname: Linux-4.0.5-gentoo-x86_64-Intel-R-_Core-TM-2_Duo_CPU_E7500_@_2.93GHz-with-gentoo-2.2
KiB Mem:     3916556 total,    722480 free
KiB Swap:    4194300 total,   4163652 free
Timestamp of repository gentoo: Fri, 19 Jun 2015 14:00:01 +0000
sh bash 4.3_p33-r2
ld GNU ld (Gentoo 2.24 p1.4) 2.24
ccache version 3.1.9 [enabled]
app-shells/bash:          4.3_p33-r2::gentoo
dev-java/java-config:     2.2.0::gentoo
dev-lang/perl:            5.20.2::gentoo
dev-lang/python:          2.7.9-r1::gentoo, 3.4.1::gentoo
dev-util/ccache:          3.1.9-r4::gentoo
dev-util/cmake:           2.8.12.2-r1::gentoo
dev-util/pkgconfig:       0.28-r2::gentoo
sys-apps/baselayout:      2.2::gentoo
sys-apps/openrc:          0.16.4::gentoo
sys-apps/sandbox:         2.6-r1::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69::gentoo
sys-devel/automake:       1.11.6-r1::gentoo, 1.14.1::gentoo
sys-devel/binutils:       2.24-r3::gentoo
sys-devel/gcc:            4.8.4::gentoo
sys-devel/gcc-config:     1.7.3::gentoo
sys-devel/libtool:        2.4.6::gentoo
sys-devel/make:           4.1-r1::gentoo
sys-kernel/linux-headers: 3.18::gentoo (virtual/os-headers)
sys-libs/glibc:           2.20-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000

science
    location: /usr/portage/local/layman/science
    masters: gentoo
    priority: 0

x-portage
    location: /usr/local/portage
    masters: gentoo
    priority: 1

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -fno-stack-protector"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -pipe -march=native -fno-stack-protector"
DISTDIR="/usr/distfiles"
EMERGE_DEFAULT_OPTS="--quiet-build=n --autounmask-write --keep-going"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs ccache config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms split-log strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.heanet.ie/pub/gentoo/"
LANG="es_ES.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j3"
PKGDIR="/usr/local/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 applet avahi bash-completion berkdb branding bzip2 cairo ccache cdda cddb cdr cli colord cracklib crypt cups cvs cxx dbus djvu dri dts dvd dvdr dvi eds emboss enchant encode evo exif fam fat ffmpeg firefox flac fortran fuse gdbm gif glamor gnome gnome-keyring gnome-online-accounts gphoto2 gpm gstreamer gtk gtk3 gtkstyle http iconv infinality introspection irc jabber jpeg kpathsea latex lcms ldap libnotify libsecret libvisual lyx mad mms mmx mmxext mng modules monolithic-build mp3 mp4 mpeg multilib musicbrainz nautilus ncurses network-cron networkmanager nls nptl ntfs numa ogg opengl openmp optimized-qmake pam pango pch pdf png policykit ppds pulseaudio qt3support qt4 readline reiserfs scanner sdl session smp spell sse sse2 ssl startup-notification svg systemd t1lib tcpd theora threads tiff tracker truetype udev udisks unicode upnp upnp-av upower usb v4l vaapi vala vcd vdpau vorbis wifi wxwidgets x264 xattr xcb xfs xml xv xvid youtube zeroconf zlib" ABI_X86="64" ALSA_CARDS="hda-intel" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 sse3 sse4_1 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="es es_ES en_US" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="fbdev vesa radeon" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CPPFLAGS, CTARGET, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
Comment 1 Ian Stakenvicius (RETIRED) gentoo-dev 2015-06-26 13:56:24 UTC
Testing against 1.8.5 is as simple as changing this line in src_configure():

$(if use hppa || use ia64 || use mips; then echo --with-mozjs=mozjs185; else echo --with-mozjs=mozjs-17.0; fi)

...to just --with-mozjs=mozjs185 ...

As for the error itself, the change to the way context and memory works in mozjs-17 vs mozjs-1.8.5 is definitely complicated enough that polkit might be triggering issues as per what is alluded to in the freedesktop bug.  IIRC there's a reason why the spidermonkey-17 dep forces off the debug flag, and technically anything using spidermonkey should still be fine despite all of the asserts that get inserted with USE="debug" but polkit isn't (again, iirc).
Comment 2 Pacho Ramos gentoo-dev 2015-07-03 09:19:11 UTC
Yeah, it looks to work ok with the older mozjs

I will probably make a revbump to use that version, that will also allow to kill :17 slot as this was the only reverse dep (this is exactly what Debian people did long time ago too with polkit vs. mozjs)
Comment 3 Pacho Ramos gentoo-dev 2015-07-04 13:27:08 UTC
0.113 uses mozjs-185
Comment 4 Oleh 2015-07-16 10:04:39 UTC
ok this is indeed related to freedesktop report and the fix is in 113 version, however this has nothing about restriction of spidermonkey dependency. This leading to https://bugs.gentoo.org/show_bug.cgi?id=554836
Comment 5 Gilles Dartiguelongue (RETIRED) gentoo-dev 2015-07-16 15:10:24 UTC
I am reopening this issue on behalf of angry_vincent on IRC.

The upstream bug says the problem should be gone in 0.113 but the ebuild still uses the 0 slot. Shouldn't we modify older ebuild to use slot 0 and use slot 17 in 0.113 release ?
Comment 6 Ian Stakenvicius (RETIRED) gentoo-dev 2015-07-16 17:29:10 UTC
(In reply to Gilles Dartiguelongue from comment #5)
> I am reopening this issue on behalf of angry_vincent on IRC.
> 
> The upstream bug says the problem should be gone in 0.113 but the ebuild
> still uses the 0 slot. Shouldn't we modify older ebuild to use slot 0 and
> use slot 17 in 0.113 release ?

so what you're saying is that you want to take your chances with spidermonkey-17 in polkit-0.113 anyways?
Comment 7 Pacho Ramos gentoo-dev 2015-07-16 18:42:39 UTC
Personally I would prefer to still use spidermonkey-1.8.5 that is the one used by Debian. Also, the only consumer of spidermonkey:17 slot was polkit (while a lot of other things are still relying on 1.8.5).

This also avoids to having spidermonkey:17 being used in a few arches and 1.8.5 on the rest for the same polkit version
Comment 8 Gilles Dartiguelongue (RETIRED) gentoo-dev 2015-07-17 06:56:08 UTC
We discussed this a bit more with pacho yesterday and I think that we agree that if spidermonkey is only used for polkit, then we might as well remove it from tree with pacho's argument about support of 1.8.5.
Comment 9 Pacho Ramos gentoo-dev 2015-07-18 06:04:08 UTC
CLosing then :)
Comment 10 Pacho Ramos gentoo-dev 2016-07-31 08:32:35 UTC
*** Bug 589998 has been marked as a duplicate of this bug. ***
Comment 11 Dainius Masiliūnas 2016-07-31 13:23:52 UTC
(In reply to Pacho Ramos from comment #7)
> Personally I would prefer to still use spidermonkey-1.8.5 that is the one
> used by Debian.

But it's not used by polkit on Debian, as far as I can gather:
https://lists.freedesktop.org/archives/polkit-devel/2015-September/000465.html
(The same discussion shows that they considered moving to Duktape, attempting to port to a newer mozjs or abandoning JavaScript rules entirely. But it's been a while since that discussion, too...)

Also, spidermonkey-17 is what is used on recent versions of openSUSE:
https://build.opensuse.org/package/view_file/openSUSE:Factory/polkit/polkit.spec?expand=1 (line 59)
 
> This also avoids to having spidermonkey:17 being used in a few arches and
> 1.8.5 on the rest for the same polkit version

But spidermonkey-1.8.5 doesn't build on x32 at the moment (bug #439558), whereas spidermonkey-17 builds fine. And this particular issue seems to indeed have been fixed in 0.113, since I don't get those kernel traps on my machine.

Why not have a USE flag to toggle it, then?
Comment 12 Pacho Ramos gentoo-dev 2016-07-31 13:48:26 UTC
We are not going to revert back to use another completely dead spidermonkey version. At least now we can mostly rely in only 185 version and 24, but we don't need to also start randomly trying to support all the broken spidermonkey supports relying on completely dead versions. 

The way to go is to kill any spidermonkey requirement, but polkit upstream has still not done that