Home | Docs | Forums | Lists | Bugs | Planet | Store | GMN | Get Gentoo!
Not eligible to see or edit group visibility for this bug.
View Bug Activity | Format For Printing | XML | Clone This Bug
Hello, this is pam_skey-1.1.3.ebuild, providing a PAM module for interfacing the S/Key library. I suggest sys-libs/pam_skey where the main PAM libraries are located, too. Uli Reproducible: Always Steps to Reproduce:
Created an attachment (id=34238) [details] pam_skey-1.1.3.ebuild
Created an attachment (id=34321) [details] pam_skey-1.1.3.ebuild Added "dodoc README INSTALL" to src_install().
When bug 65343 is fixed, this will no longer be needed (at least for sshd).
Created an attachment (id=52094) [details] pam_skey-1.1.3-r1.ebuild Updated SRC_URI to a live copy of the source. Added my own gentoo-r1 patch (URL is live). Add src_unpack, updated src_compile (--libdir should have been specified, not --exec_prefix) and src_install to fit with the new patch. My gentoo-r1 patch is a major rewrite of the pam_skey authentication code; it makes the module more compliant with PAM standards. See the README and INSTALL files included with the patch.
Created an attachment (id=52095) [details] files/pam_skey-system-auth.pam.d This is the replacement pam.d/system-auth config file that pam_skey-1.1.3-r1 uses.
I just want to note that bug 36499 and this one concern the same thing, so one of them should be resolved as a duplicate.
I noticed that as well; I added the update to this one because (a) this bug is more recent, so hopefully it has more active people watching it, and (b) the ebuild file with this bug was cleaner. In any case, the important part of my update isn't the ebuild at all, but the patch that it refers to.
*** Bug 36499 has been marked as a duplicate of this bug. ***
HOMEPAGE is no longer valid and should be changed to http://freshmeat.net/projects/pam_skey/ Version 1.1.4 is out since some time (only minuscule changes, though).
Created an attachment (id=81391) [details] pam_skey-1.1.3-r1.ebuild slightly modified ebuild (homepage, inherit pam eclass, deps)
Created an attachment (id=81392) [details] files/pam_skey-system-auth.pam.d files/pam_skey-system-auth.pam.d - slightly modified to match current pam version
Tested this w/ openssh-4.2_p1-r1, works nicely. I also tried to redo the patches for 1.1.4 but the two big ones are too much work, don't have time for that. :/
I've looked through the changes from pam_skey-1.1.3 to pam_skey-1.1.4, and the only code changes are bugfixes to bugs that don't exist in my code. Since my patch involved a rewrite of the entirety of pam_skey.c (and removing pam_skey_access.c) the codebase is completely different. My recommendation is to keep pam_skey-1.1.3-r1 as the current version of the ebuild, as making a 1.1.4-r1 patch and ebuild would provide no further benefits.
Apart from changes related to the new autoconf version, the differences between 1.1.3 and 1.1.4 are small. So it really is not a big issue to base the patch on 1.1.4. See attachment. Dany, did you consider sending your patch to Upstream? Or is it too Gentoo specific?
Created an attachment (id=81492) [details] pam_skey-1.1.4-gentoo.patch
(In reply to comment #14) > Dany, did you consider sending your patch to Upstream? Or is it too Gentoo > specific? Indeed, good idea... (In reply to comment #15) > Created an attachment (id=81492) [edit] [details] > pam_skey-1.1.4-gentoo.patch I'll give a try as soon as I have time, thanks.
Created an attachment (id=81505) [details] pam_skey-1.1.4-gentoo.patch (take 2) Took out unnecessary hunk for REALEASENOTES.
(In reply to comment #17) Works fine w/ openssh and sudo.
I considered sending in the patch; the only reason I didn't was because I made a number of assumptions while writing my code; I don't know how portable it would be to other systems (Linux using a different skey library, *BSD). That's why I took out many of the configure defines. So, yes, the new code is in general suitable for any PAM system; however, it might need work to make it portable.
This is now in our Project Sunrise overlay: svn co http://overlays.gentoo.org/svn/proj/sunrise Enjoy!
Created an attachment (id=90101) [details] pam_skey-1.1.4 ebuild
*Pretty please* remove this from sunrise, installing a new system-auth file is a no-go situation, and will most likely create _more_ problems for the PAM team (that is: me alone).
(In reply to comment #22) Done.
Actually, it isn't removed but fixed. <http://overlays.gentoo.org/proj/sunrise/changeset/4196>
Committed to Portage tree, thanks everybody. *pam_skey-1.1.4 (16 Jan 2008) 16 Jan 2008; Ulrich Mueller <ulm@gentoo.org> +metadata.xml, +pam_skey-1.1.4.ebuild: Import from Sunrise overlay. Original ebuild and patch contributed by Dani Church <dani.church@gmail.com>, Jakub Moc <jakub@gentoo.org> and me, bug 55279.
