Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 55262 - gcc-config cleanup patch
Summary: gcc-config cleanup patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Toolchain Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-06-26 10:21 UTC by ferret
Modified: 2004-07-24 13:39 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to remove gcc-config's dependency on which (gcc-config-nowhich.patch,623 bytes, patch)
2004-06-26 10:22 UTC, ferret
Details | Diff
fixed patch (attachment.cgi,620 bytes, patch)
2004-06-28 10:32 UTC, ferret
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ferret 2004-06-26 10:21:31 UTC
gcc-config needs some cleanup.  It does weird things like "which which" which
just aren't necessary. :)

Since its interpreter in /bin/bash, it can ue the bash builtin "type -path" for
the exact same effect, removeing a dependency on which.

In stage tarballs, which doesn't exist. I don't know if gcc-config does, and
gcc-config contains some backup code in case which fails for any reason, but I
still think this cleanup is necessay to kill any bugs-in-waiting and just because
it makes for nicer code.
Comment 1 ferret 2004-06-26 10:22:32 UTC
Created attachment 34208 [details, diff]
patch to remove gcc-config's dependency on which
Comment 2 Martin Schlemmer (RETIRED) gentoo-dev 2004-06-27 02:11:27 UTC
Problem I have, is that it breaks if you have an alias set for what you
querry:

--
azarah@nosferatu azarah $ type -path cp
azarah@nosferatu azarah $ type -path rm
azarah@nosferatu azarah $ type -path mv
azarah@nosferatu azarah $ type -path ln
/bin/ln
--

Sure, you can now first unset the alias first, but now you have to check if
the alias exists, and then unset it, etc, so it gets as hairy, if not more ...
Comment 3 ferret 2004-06-28 10:32:45 UTC
Created attachment 34337 [details, diff]
fixed patch

Thanks for the advice.
Comment 4 Martin Schlemmer (RETIRED) gentoo-dev 2004-07-01 10:08:12 UTC
Ditto, more like it.
Comment 5 Martin Schlemmer (RETIRED) gentoo-dev 2004-07-24 13:39:27 UTC
Done, thanks.