Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 551884 - media-tv/tvheadend-4.0.4 version bump
Summary: media-tv/tvheadend-4.0.4 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Leho Kraav (:macmaN @lkraav)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-06-12 12:22 UTC by Torsten Kurbad
Modified: 2015-10-13 11:31 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
tvheadend-3.4.27_4.0.4.ebuild.diff (tvheadend-3.4.27_4.0.4.ebuild.diff,1.09 KB, patch)
2015-06-12 12:23 UTC, Torsten Kurbad
Details | Diff
tvheadend 4.0.6 ebuild (tvheadend-4.0.6.ebuild,2.58 KB, text/plain)
2015-09-27 14:03 UTC, Olliver Schinagl
Details
glibc iconv patch (4.0.6-use-glibc-version-iconv.patch,921 bytes, patch)
2015-09-27 14:04 UTC, Olliver Schinagl
Details | Diff
build.log (build.log,4.17 KB, text/plain)
2015-10-05 06:34 UTC, Sam Jorna (wraeth)
Details
tvheadend-4.0.6.ebuild (tvheadend-4.0.6.ebuild,3.01 KB, text/plain)
2015-10-12 14:42 UTC, Sam Jorna (wraeth)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Kurbad 2015-06-12 12:22:58 UTC
tvheadend's 4.x releases are maturing. Please add an ebuild for the current stable version 4.0.4.

I was able to merge tvheadend-4.0.4 successfully by applying the attached patch to the tvheadend-3.4.27.ebuild.

Thanks and best regards,
Torsten

Reproducible: Always
Comment 1 Torsten Kurbad 2015-06-12 12:23:30 UTC
Created attachment 405022 [details, diff]
tvheadend-3.4.27_4.0.4.ebuild.diff
Comment 2 Olliver Schinagl 2015-09-27 14:03:32 UTC
Created attachment 413068 [details]
tvheadend 4.0.6 ebuild

Updated tvheadend ebuild for TVHeadend 4.0.6
Comment 3 Olliver Schinagl 2015-09-27 14:04:25 UTC
Created attachment 413070 [details, diff]
glibc iconv patch

This patch fixes the build system to work with glibc's iconv

This patch will probably fail if libiconv is installed
Comment 4 Olliver Schinagl 2015-09-27 14:06:39 UTC
New ebuild for tvheadend 4.0.6

there is a known issue with this ebuild when using libiconv.

When using glibc's iconv we get a iconv.h but no libiconv. When using the libiconv package, we get iconv.h and libiconv.so. So when glibc's version is being used, the Makefile detect iconv via iconv.h but the test program fails to compile (and the final code) due to missing libiconv.so from -liconv (hence the patch).
Comment 5 Ian Delaney (RETIRED) gentoo-dev 2015-10-04 09:58:15 UTC
Olliver Schinagl do you wish to be a co proxy maintainer?
Comment 6 Sam Jorna (wraeth) gentoo-dev 2015-10-05 06:34:26 UTC
Created attachment 413766 [details]
build.log

build.log of tvheadend-4.0.6 failing as it performs a fetch as part of the configure process, meaning the build will fail when the machine is offline.
Comment 7 Sam Jorna (wraeth) gentoo-dev 2015-10-05 06:40:04 UTC
This appears to be part of the upstream configure script [1]. Given the `elif [ ! -d "${DIR}" ]; then` stanza in the script, this requirement should probably be packaged separately and added as a separate ebuild to portage upon which tvheadend has in DEPEND.

1: https://github.com/tvheadend/tvheadend/blob/6f7ddb36d39d878c894f883625752a5a53a3fe9b/support/getmuxlist
Comment 8 Sam Jorna (wraeth) gentoo-dev 2015-10-05 07:13:46 UTC
It is worth noting that when online, the build succeeds and installs successfully when built with either USE="iconv" or USE="-iconv".

Also note that I can't speak to the funcionality of the installed package.
Comment 9 Amy Liffey gentoo-dev 2015-10-05 07:42:37 UTC
So it seems to be working fine as wraeth tested for us. I wonder if you tested it with USE="-iconv" as well?

Can you please follow all tips by wraeth. Here's a link that outlines the  restriction on builds to not download during building.

https://devmanual.gentoo.org/ebuild-writing/functions/

If you have any questions you can ask here or you can find us on #gentoo-proxy-maint irc.freenode.net.

Thanks

Amynka
Comment 10 Olliver Schinagl 2015-10-05 08:25:59 UTC
(In reply to Ian Delaney from comment #5)
> Olliver Schinagl do you wish to be a co proxy maintainer?

I don't mind if it's not very time consuming ;)
Comment 11 Ian Delaney (RETIRED) gentoo-dev 2015-10-05 08:30:16 UTC
Olliver Schinagl;

It's not time consuming to manage one package. However this package needs a bit of work all of which is outlined in prior comments.

proxy maintainers are keen users who are prepared to put the time in to make a proper ebuild. The ebuild of this has a major issue which however will require fixing only once.

Your decision.
Comment 12 Olliver Schinagl 2015-10-05 08:54:50 UTC
(In reply to Sam Jorna (wraeth) from comment #7)
> This appears to be part of the upstream configure script [1]. Given the
> `elif [ ! -d "${DIR}" ]; then` stanza in the script, this requirement should
> probably be packaged separately and added as a separate ebuild to portage
> upon which tvheadend has in DEPEND.
> 
> 1:
> https://github.com/tvheadend/tvheadend/blob/
> 6f7ddb36d39d878c894f883625752a5a53a3fe9b/support/getmuxlist

The thing is, we used to depend on v4l-utils which packaged the scantables. We split those upstream from the v4l-utils package and have a seperate package for the scantables. I have not yet taken the time to write a package for the dtv-scan-tables on which we could depend.

So until then, we use the upstream git fetch method :) Disabeling the dvbscan flag makes it offline able :)
Comment 13 Sam Jorna (wraeth) gentoo-dev 2015-10-05 09:51:33 UTC
An alternative to making a separate package for the dvt-scan-tables requirement could also be to include a snapshot of its repository in SRC_URI [1], meaning that SRC_URI lists both the archive for both tvheadend itself as well as the archive for dvt-scan-tables.

This would also mean src_unpack() would need to be written [2] to extract the archive in the correct location.

That being said, if the package is suitable without the dvt-scan-tables, then so be it - let Amy or Ian know and they can help you move forward with it.

1: https://devmanual.gentoo.org/ebuild-writing/variables/index.html#src_uri
2: https://devmanual.gentoo.org/ebuild-writing/functions/src_unpack/
Comment 14 Ian Delaney (RETIRED) gentoo-dev 2015-10-05 15:34:24 UTC
Disabling the dvbscan flag makes it offline able
means it is an optional runtime feature. If so, then disable it by patch and continue.  The build CANNOT have d'loading past src_fetch.
The practice of bundling is a constant challenge / annoyance to package making in gentoo, but of gentoo's own design or choice.  A build need be able to take place on a machine without connection to the internet.

Otherwise Sam has outlined the option to you of making a separate package. That means a brand new ebuild, from scratch.
Comment 15 Sam Jorna (wraeth) gentoo-dev 2015-10-12 14:42:25 UTC
Created attachment 414450 [details]
tvheadend-4.0.6.ebuild

Modified ebuild for tvheadend which includes dvb-scan-tables in SRC_URI (preventing fetch during build). Repoman tests pass with the exception of a bad dep on media-libs/libhdhomerun which is missing ~86 in KEYWORDS. Note this also requires attachment 413070 [details, diff] as a patch. Runtest works for me.
Comment 16 Ian Delaney (RETIRED) gentoo-dev 2015-10-13 11:28:44 UTC
commit 90707a8ef54250b4bca083184beed7d39aff17e3
Author: Ian Delaney <idella4@gentoo.org>
Date:   Tue Oct 13 19:22:54 2015 +0800

    media-tv/tvheadend: bump to -4.0.6, patch to fixing issues re IUSE iconv
    
    patch submitted thanks to Olliver Schinagl, ebuild prepared by new
    designated proxy maintainer 'wraeth' submitted via gentoo bug,
    old versions removed on request of maintainer.
    
    Gnetoo bug: #551884
    

commit 9d1737b41c36de65efb63a08b508f66f99a2b60c
Author: Ian Delaney <idella4@gentoo.org>
Date:   Tue Oct 13 17:23:22 2015 +0800

    media-libs/libhdhomerun add x86 keyword