Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 551522 - Fluxbox 1.3.7-r1 doesn't control toolbar correctly
Summary: Fluxbox 1.3.7-r1 doesn't control toolbar correctly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: zlg (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 551350
  Show dependency tree
 
Reported: 2015-06-08 21:11 UTC by Philip Webb
Modified: 2015-06-13 21:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
output of 'emerge --info' (emerge-anb4.d1,3.96 KB, text/plain)
2015-06-08 21:11 UTC, Philip Webb
Details
Fluxbox init file (init,3.35 KB, text/plain)
2015-06-08 21:13 UTC, Philip Webb
Details
patch to fix toolbar hiding (fluxbox-1.3.7-r2_fix-hidden-toolbar.patch,5.28 KB, patch)
2015-06-09 04:20 UTC, zlg (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Webb 2015-06-08 21:11:59 UTC
Created attachment 404786 [details]
output of 'emerge --info'

Recently, I updated to Fluxbox 1.3.7-r1 (1.3.7 shows the same problem).
I have the toolbar at the bottom centre of the screen & Fbpager at the bottom left, both ordinarily hidden.  With 1.3.6-r1, when I move the mouse-pointer down to the bottom, the toolbar or pager appear, depending whether it's at the centre or left.  With 1.3.7-r1, when I move the pointer down to the centre, the toolbar fails to appear ; when the pointer is at the bottom left, the toolbar appears, but not the pager, & the toolbar flickers till I manage to move the pointer from the bottom-left to the bottom-centre, when the toolbar stops flickering & remains in the normal state till I move the pointer away again.

There has been no change of config files when using the two versions.
Fbpager is version 20090221.  The use flags for Fluxbox (both versions) are
"imlib slit toolbar truetype vim-syntax -bidi -nls -xinerama" (shown by Eix).
I have tried to create a log file, but can't get it to appear : if you need that, please advise how to obtain it.
Comment 1 Philip Webb 2015-06-08 21:13:07 UTC
Created attachment 404788 [details]
Fluxbox init file
Comment 2 Andrew Miller 2015-06-09 02:09:36 UTC
(In reply to Philip Webb from comment #0)
> I have tried to create a log file, but can't get it to appear : if you need
> that, please advise how to obtain it.

PORT_LOGDIR="/var/log/portage" emerge =x11-wm/fluxbox-1.3.7-r1

Please attach the build log. It's helpful to people trying to reproduce the bug.
Comment 3 zlg (RETIRED) gentoo-dev 2015-06-09 03:08:24 UTC
Hi! After working to reproduce this, it seems to be a bug in the way Fluxbox handles toolbar hiding. When the toolbar is hidden, it gets lodged against the far left side of the display. The slit's hiding mechanism works as expected.

The live ebuild doesn't have this problem, so something between 1.3.7 and current git fixed this problem. I'll do what I can to see if I can backport the fix via a patch.

In the mean time, you can add "x11-wm/fluxbox **" to /etc/portage/package.accept_keywords and `emerge -a1 fluxbox` to use the latest git version, which has this bug fixed. Or you can wait until an ebuild that includes the patch is pushed to the tree.

Regardless, thanks for reporting this.
Comment 4 zlg (RETIRED) gentoo-dev 2015-06-09 04:00:16 UTC
fluxbox-1.3.7-r2.ebuild includes the patch necessary to fix this bug. It should hit mirrors fairly soon.
Comment 5 zlg (RETIRED) gentoo-dev 2015-06-09 04:20:45 UTC
Created attachment 404804 [details, diff]
patch to fix toolbar hiding

This is the patch that fixed the bug. The problem was that the X coordinate of the toolbar wasn't being used when it was 'morphing' to its hidden state. This caused the toolbar to always be on the far left side of the screen when it's hidden, resulting in the "flipping" experienced by the user.

The patch ensures that the toolbar moves where it needs to be on the X axis when hidden, resulting in predictable behavior.

It was produced via running `git-diff Release-1_3_7..69d13 src/Toolbar.cc` on the repository found at http://git.fluxbox.org .
Comment 6 Philip Webb 2015-06-09 13:09:42 UTC
(In reply to Andrew Miller from comment #2)
> (In reply to Philip Webb from comment #0)
> > I have tried to create a log file, but can't get it to appear : if you need
> > that, please advise how to obtain it.
> 
> PORT_LOGDIR="/var/log/portage" emerge =x11-wm/fluxbox-1.3.7-r1
> 
> Please attach the build log. It's helpful to people trying to reproduce the
> bug.

I meant the Fluxbox log, which should appear after 'fluxbox -log <file>'.
Comment 7 Philip Webb 2015-06-09 13:13:58 UTC
(In reply to Daniel Campbell from comment #4)
> fluxbox-1.3.7-r2.ebuild includes the patch necessary to fix this bug. It
> should hit mirrors fairly soon.

Thanks for your very prompt & clear explanation & fix.
I'll wait to see if -r2 has appeared by Saturday (my next update).
Comment 8 Philip Webb 2015-06-13 21:02:28 UTC
I've installed 1.3.7-r2 & the problem has gone.  Thanks again.

PS the defective 1.3.7-r1 is still in "stable" : is that an oversight ?