551158 – app-text/poppler: incorrect use of nonfatal

Bug 551158 - app-text/poppler: incorrect use of nonfatal

Summary: app-text/poppler: incorrect use of nonfatal

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Maciej Mrozowski

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:	bad-nonfatal
	Show dependency tree

Reported:	2015-06-04 09:00 UTC by Michał Górny
Modified:	2015-06-21 12:01 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michał Górny archtester

2015-06-04 09:00:45 UTC

if use cairo && use doc; then
        # For now install gtk-doc there
        insinto /usr/share/gtk-doc/html/poppler
        # nonfatal, because live version doesn't provide html documentation.
        nonfatal doins -r "${S}"/glib/reference/html/*
fi


nonfatal is meant to provide custom error handling, not allow you to ignore errors. Check for the live version properly rather than assuming every error is fine.

Comment 1 Johannes Huber (RETIRED) gentoo-dev

2015-06-21 12:01:53 UTC

Thanks for reporting. This is fixed in cvs now.

+
+  21 Jun 2015; Johannes Huber <johu@gentoo.org> -poppler-0.33.0.ebuild,
+  poppler-0.33.0-r1.ebuild, poppler-9999.ebuild:
+  Replace nonfatal usage with live version check, bug #551158. Sync live. Remove
+  old.
+