Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 550678 - >=net-p2p/bitcoin-qt-0.10[qt5] should depend on dev-qt/linguist-tools:5, dev-qt/qtnetwork:5 and dev-qt/qtwidgets:5
Summary: >=net-p2p/bitcoin-qt-0.10[qt5] should depend on dev-qt/linguist-tools:5, dev-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-05-28 18:37 UTC by Oleh
Modified: 2015-05-30 19:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
config.log for dev-qt/qtnetwork:5 installed, dev-qt/qtwidgets:5 installed and dev-qt/linguist-tools:5 not installed (config.log,91.37 KB, text/plain)
2015-05-28 18:38 UTC, Oleh
Details
config.log for dev-qt/qtnetwork:5 installed, dev-qt/qtwidgets:5 installed and dev-qt/linguist-tools:5 not installed (config.log,91.37 KB, text/plain)
2015-05-28 18:54 UTC, Oleh
Details
config.log for dev-qt/qtnetwork:5 not installed, dev-qt/qtwidgets:5 not installed and dev-qt/linguist-tools:5 not installed (config.log,87.11 KB, text/plain)
2015-05-28 19:00 UTC, Oleh
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oleh 2015-05-28 18:37:51 UTC
With USE=qt5 configure unable to find Qt because it has missing dependencies:
dev-qt/qtnetwork
dev-qt/qtwidgets


Reproducible: Always

Steps to Reproduce:
1. USE=qt5 emerge bitcoin-qt
2. notice a failure at configure phase.
3.
Actual Results:  
checking for QT... no
configure: error: Qt dependencies not found

Expected Results:  
Ebuild has complete dependencies and compiled.
Comment 1 Oleh 2015-05-28 18:38:16 UTC
Created attachment 404200 [details]
config.log for dev-qt/qtnetwork:5 installed, dev-qt/qtwidgets:5 installed and dev-qt/linguist-tools:5 not installed
Comment 2 Oleh 2015-05-28 18:54:51 UTC
Created attachment 404210 [details]
config.log for dev-qt/qtnetwork:5 installed, dev-qt/qtwidgets:5 installed and dev-qt/linguist-tools:5 not installed
Comment 3 Oleh 2015-05-28 19:00:17 UTC
Created attachment 404214 [details]
config.log for dev-qt/qtnetwork:5 not installed, dev-qt/qtwidgets:5 not installed and dev-qt/linguist-tools:5 not installed
Comment 4 Anthony Basile gentoo-dev 2015-05-29 12:41:52 UTC
(In reply to Oleg from comment #3)
> Created attachment 404214 [details]
> config.log for dev-qt/qtnetwork:5 not installed, dev-qt/qtwidgets:5 not
> installed and dev-qt/linguist-tools:5 not installed

I can't test because I don't have a qt5 system, but this looks correct.

@reporter, the title and comment #0 are saying different things.  The title has dev-qt/linguist-tools:5 as well.  Can you clarify, or better yet, just provide a patch against the ebuild.
Comment 5 Oleh 2015-05-29 14:14:05 UTC
it is sufficient to understand from config logs about missing dependencies. It's quite bad to commit ebuilds without actually having a test environment. It can be even chroot.
Comment 6 Luke-Jr 2015-05-30 04:47:10 UTC
Fixed in overlay.

@blueness, overlay's maintree_20150523:net-p2p/bitcoin-qt/bitcoin-qt-0.10.2.ebuild is updated with this and bug 550690, to be copied to the main tree.
Comment 7 Anthony Basile gentoo-dev 2015-05-30 17:52:25 UTC
(In reply to Luke-Jr from comment #6)
> Fixed in overlay.
> 
> @blueness, overlay's
> maintree_20150523:net-p2p/bitcoin-qt/bitcoin-qt-0.10.2.ebuild is updated
> with this and bug 550690, to be copied to the main tree.

Done.  BTW, I don't have push access to https://gitlab.com/bitcoin/gentoo.git.  vapier added an important fix to bitcoin-qt-0.10.x which should be backported to the overlay.


diff --git a/net-p2p/bitcoin-qt/bitcoin-qt-0.10.2.ebuild b/net-p2p/bitcoin-qt/bitcoin-qt-0.10.2.ebuild
index b20460d..2959807 100644
--- a/net-p2p/bitcoin-qt/bitcoin-qt-0.10.2.ebuild
+++ b/net-p2p/bitcoin-qt/bitcoin-qt-0.10.2.ebuild
@@ -1,6 +1,6 @@
 # Copyright 2010-2015 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2
-# $Header: /var/cvsroot/gentoo-x86/net-p2p/bitcoin-qt/bitcoin-qt-0.9.3.ebuild,v 1.2 2014/10/10 11:30:23 blueness Exp $
+# $Header: /var/cvsroot/gentoo-x86/net-p2p/bitcoin-qt/bitcoin-qt-0.10.2.ebuild,v 1.4 2015/05/30 17:47:11 blueness Exp $
 
 EAPI=5
 
@@ -62,6 +62,13 @@ src_prepare() {
        sed "s/locale\/${filt}/bitcoin.qrc/" -i 'src/Makefile.qt.include'
        einfo "Languages -- Enabled:$yeslang -- Disabled:$nolang"
 
+       if has_version '>=dev-libs/leveldb-1.18-r1'; then
+               # Newer leveldb has changed header location.
+               sed -i \
+                       -e '/#include/s:memenv.h:leveldb/helpers/memenv.h:' \
+                       src/leveldbwrapper.cpp || die
+       fi
+
        bitcoincore_autoreconf
 }
Comment 8 Luke-Jr 2015-05-30 19:31:07 UTC
(In reply to Anthony Basile from comment #7)
> BTW, I don't have push access to
> https://gitlab.com/bitcoin/gentoo.git.

What's your GitLab username?

> vapier added an important fix to
> bitcoin-qt-0.10.x which should be backported to the overlay.

This fix should not be necessary for either 0.9.5 or 0.10.2. I fixed it in the upstream sys_leveldb patching.