Bug 548708 – net-misc/vinagre-3.14.3 with USE="rdp" fails to build with net-misc/freerdp-1.2.1_pre20150326

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Chris Mayo 2015-05-05 19:30:52 UTC]

plugins/rdp/vinagre-rdp-tab.c: In function ‘open_freerdp’:
plugins/rdp/vinagre-rdp-tab.c:890:11: error: ‘rdpSettings’ has no member named ‘DisableEncryption’
   settings->DisableEncryption = FALSE;
           ^
Makefile:1660: recipe for target 'plugins/rdp/vinagre_vinagre-vinagre-rdp-tab.o' failed
make[2]: *** [plugins/rdp/vinagre_vinagre-vinagre-rdp-tab.o] Error 1


emerges fine with net-misc/freerdp-1.1.0_beta1_p20130710-r1

[Comment 1 Nick Andrade 2015-05-06 06:58:47 UTC]

Created attachment 402744 [details, diff]
vinagre-rdp-1.2.1.patch

It probably makes sense to just add the contents of this patch to the existing plugins/rdp/vinagre-rdp-tab.c.

[Comment 2 Nick Andrade 2015-05-06 06:59:14 UTC]

Looks like that was one of the deprecated options in commit 6424599639425212096340cd24c1bc35380ecc60 (https://github.com/FreeRDP/FreeRDP/commit/6424599639425212096340cd24c1bc35380ecc60).  Removing the line in plugins/rdp/vinagre-rdp-tab.c resolves the issue and shouldn't cause any breakage.  A patch to do that is attached (note: vinagre-3.14.3 does not have epatch_user).

[Comment 3 Pacho Ramos 2015-05-07 19:09:02 UTC]

I don't see any similar patch in "master" upstream branch, I think you should report this to upstream then to ensure they review it -> bugzilla.gnome.org

Thanks

[Comment 4 Nick Andrade 2015-05-08 15:34:18 UTC]

I've gone ahead and submitted this bug and patch upstream: https://bugzilla.gnome.org/show_bug.cgi?id=749124

[Comment 5 Nick Andrade 2015-05-12 03:25:12 UTC]

Created attachment 403094 [details, diff]
vinagre-rdp-1.2.1.patch

Updated version of the patch to reflect that the setting has been renamed from "DisableEncryption" to "UseRdpSecurityLayer" (see https://github.com/FreeRDP/FreeRDP/pull/2273).  Updated patch also submitted to Gnome upstream.

[Comment 6 Nick Andrade 2015-05-16 06:53:28 UTC]

Created attachment 403360 [details, diff]
vinagre-3.14.3-rdp-1.2.1.patch

Hopefully final version of patch.  Added ifdefs to take care of folks on older versions of freerdp (which hopefully aren't many as we get freerdp 1.2.1 stable).

[Comment 7 Peter Asplund 2015-05-16 09:51:01 UTC]

Upstream has now committed the patch and bug marked as resolved fixed.

[Comment 8 Pacho Ramos 2015-05-16 12:16:43 UTC]

+*vinagre-3.14.3-r1 (16 May 2015)
+
+  16 May 2015; Pacho Ramos <[e-mail]>
+  +files/vinagre-3.14.3-freerdp2.patch, +vinagre-3.14.3-r1.ebuild,
+  -vinagre-3.12.2.ebuild:
+  Fix building with latest freerdp (#548708 by Chris Mayo and Nick Andrade),
+  IPV6 kernel support is needed (#518574 by Lubos Kolouch), drop old.
+