freerdp 1.2.1 fails to build while linking on ARM-hardfloat machine. Problem seems to be independent of GCC-version and CFLAGS: /usr/lib/gcc/armv7a-hardfloat-linux-gnueabi/4.9.2/../../../../armv7a-hardfloat-linux-gnueabi/bin/ld: error: libfreerdp.so.1.2.1 uses VFP register arguments, CMakeFiles/freerdp.dir/codec/rfx_neon.c.o does not /usr/lib/gcc/armv7a-hardfloat-linux-gnueabi/4.9.2/../../../../armv7a-hardfloat-linux-gnueabi/bin/ld: failed to merge target specific data of file CMakeFiles/freerdp.dir/codec/rfx_neon.c.o Reproducible: Always Steps to Reproduce: 1. Install Gentoo hardfloat on ARM machine 2. emerge -av =net-misc/freerdp-1.2.1_pre20150326 Actual Results: build fails at linking phase Expected Results: build just fine Hardware is NVidia Tegra K1
build.log: http://jpst.it/yl36
Portage 2.2.14 (python 2.7.9-final-0, default/linux/arm/13.0/armv7a/desktop, gcc-4.9.2, glibc-2.20-r2, 3.10.18 armv7l) ================================================================= System Settings ================================================================= System uname: Linux-3.10.18-armv7l-with-gentoo-2.2 KiB Mem: 4105368 total, 2437048 free KiB Swap: 0 total, 0 free Timestamp of tree: Sat, 18 Apr 2015 00:15:01 +0000 ld GNU ld (Gentoo 2.25 p1.0) 2.25 app-shells/bash: 4.2_p53 dev-java/java-config: 2.2.0 dev-lang/perl: 5.20.1-r4 dev-lang/python: 2.7.9-r1, 3.3.5-r1, 3.4.1 dev-util/cmake: 2.8.12.2-r1 dev-util/pkgconfig: 0.28-r1 sys-apps/baselayout: 2.2 sys-apps/openrc: 0.13.11 sys-apps/sandbox: 2.6-r1 sys-devel/autoconf: 2.13, 2.69 sys-devel/automake: 1.11.6-r1, 1.13.4 sys-devel/binutils: 2.25 sys-devel/gcc: 4.8.3, 4.9.2 sys-devel/gcc-config: 1.7.3 sys-devel/libtool: 2.4.4 sys-devel/make: 4.0-r1 sys-kernel/linux-headers: 3.16 (virtual/os-headers) sys-libs/glibc: 2.20-r2 Repositories: gentoo swabbles-overlay ACCEPT_KEYWORDS="arm" ACCEPT_LICENSE="* -@EULA" CBUILD="armv7a-hardfloat-linux-gnueabi" CFLAGS="-Os -pipe -mcpu=cortex-a15 -mfpu=vfpv4 -mfloat-abi=hard" CHOST="armv7a-hardfloat-linux-gnueabi" CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-Os -pipe -mcpu=cortex-a15 -mfpu=vfpv4 -mfloat-abi=hard" DISTDIR="/usr/portage/distfiles" FCFLAGS="-O2 -pipe -march=armv7-a" FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync" FFLAGS="-O2 -pipe -march=armv7-a" GENTOO_MIRRORS="http://de-mirror.org/gentoo/ http://ftp-stud.hs-esslingen.de/pub/Mirrors/gentoo/" LANG="de_DE.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j4" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/var/lib/layman/swabbles-overlay" SYNC="rsync://192.168.0.1/gentoo-portage" USE="X a52 aac acl acpi alsa arm armv5te armv6 armv6t2 berkdb bluetooth branding bzip2 cairo cdda cdr cli consolekit cracklib crypt cups cxx dbus dri dts dvd dvdr emboss encode exif fam firefox flac fortran gdbm gif glamor gpm gtk iconv ipv6 jpeg lcms ldap libnotify mad mng modules mp3 mp4 mpeg ncurses neon nls nptl ogg opengl openmp pam pango pcre pdf png policykit ppds qt3support readline sdl session spell ssl startup-notification svg tcpd tiff truetype udev udisks unicode upower usb vorbis wxwidgets xcb xml xv xvid zlib" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev synaptics mouse keyboard" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LINGUAS="de" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-5" PYTHON_SINGLE_TARGET="python2_7" PYTHON_TARGETS="python2_7 python3_3" RUBY_TARGETS="ruby19 ruby20" USERLAND="GNU" VIDEO_CARDS="dummy fbdev v4l modesetting" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, USE_PYTHON
build fails too with: armv7a-hardfloat-linux-gnueabi-4.8.3 and CFLAGS with NEON enabled. if build logs of this are needed they can be provided, too
Please attach your build logs to this bug. Pastebins have a tendency of randomly disappearing.
Created attachment 401954 [details] build.log Clang
Created attachment 401956 [details] build.log gcc
I tested to compile with clang and different versions of gcc, but no success.
looks like the build hardcodes softfp in some places which is a terrible idea [0mcd /var/tmp/portage/net-misc/freerdp-1.2.1_pre20150326/work/freerdp-1.2.1_pre20150326_build/libfreerdp && /usr/bin/armv7a-hardfloat-linux-gnueabi-gcc -DCMAKE_BUILD_TYPE=Gentoo -DEXT_PATH=\"/usr/lib/freerdp/extensions\" -DHAVE_CONFIG_H -DWITH_X11 -DWITH_XKBFILE -Dfreerdp_EXPORTS -DNDEBUG -Os -pipe -mcpu=cortex-a15 -mfpu=vfpv4 -mfloat-abi=hard -Wall -Wno-unused-result -Wno-unused-but-set-variable -Wno-deprecated-declarations -Wimplicit-function-declaration -Wredundant-decls -g -DWINPR_EXPORTS -DFREERDP_EXPORTS -fPIC -I/var/tmp/portage/net-misc/freerdp-1.2.1_pre20150326/work/freerdp-1.2.1_pre20150326_build -I/var/tmp/portage/net-misc/freerdp-1.2.1_pre20150326/work/freerdp-1.2.1_pre20150326_build/include -I/var/tmp/portage/net-misc/freerdp-1.2.1_pre20150326/work/freerdp-1.2.1_pre20150326/include -I/var/tmp/portage/net-misc/freerdp-1.2.1_pre20150326/work/freerdp-1.2.1_pre20150326/winpr/include -I/var/tmp/portage/net-misc/freerdp-1.2.1_pre20150326/work/freerdp-1.2.1_pre20150326_build/winpr/include -mfpu=neon -mfloat-abi=softfp -Wno-unused-variable -o CMakeFiles/freerdp.dir/codec/rfx_neon.c.o -c /var/tmp/portage/net-misc/freerdp-1.2.1_pre20150326/work/freerdp-1.2.1_pre20150326/libfreerdp/codec/rfx_neon.c notice the -mfloat-abi=softfp at the end, and the -mfpu=neon. this package might need a USE=neon flag in addition to fixing of the float ABI.
There are a couple of cmake options we can play with here. What would be the best way to set WITH_NEON and ARM_FP_ABI? if(TARGET_ARCH MATCHES "ARM") if (NOT DEFINED WITH_NEON) option(WITH_NEON "Enable NEON optimization." ON) else() option(WITH_NEON "Enable NEON optimization." OFF) endif() if (NOT DEFINED ARM_FP_ABI) set(ARM_FP_ABI "softfp" CACHE STRING "Floating point ABI to use on arm") else() set(ARM_FP_ABI ${ARM_FP_API} CACHE STRING "Floating point ABI to use on arm") endif() mark_as_advanced(ARM_FP_ABI)
(In reply to Mike Gilbert from comment #9) Are USE flags appropriate, or should the ebuild do some automatic detection based on some other variables?
(In reply to Mike Gilbert from comment #10) there's a USE=neon you should use. for the float ABI, the build shouldn't do anything at all -- it should let the existing compiler settings DTRT. can you just set ARM_FP_API="" ?
(In reply to SpanKY from comment #11) > for the float ABI, the build shouldn't do anything at all -- it should let > the existing compiler settings DTRT. can you just set ARM_FP_API="" ? That would result in "-mfloat-abi=" being passed to the compiler for some subset of files.
+ 30 Apr 2015; Mike Gilbert <floppym@gentoo.org> + freerdp-1.2.1_pre20150326.ebuild, freerdp-9999.1.ebuild: + Add neon use flag, bug 547246.
(In reply to Mike Gilbert from comment #12) https://github.com/FreeRDP/FreeRDP/blob/master/libfreerdp/CMakeLists.txt#L159 https://github.com/FreeRDP/FreeRDP/blob/master/libfreerdp/CMakeLists.txt#L239
(In reply to Mike Gilbert from comment #14) > (In reply to Mike Gilbert from comment #12) > > https://github.com/FreeRDP/FreeRDP/blob/master/libfreerdp/CMakeLists.txt#L159 > > https://github.com/FreeRDP/FreeRDP/blob/master/libfreerdp/CMakeLists.txt#L239 The package compiles with unset neon flag now, but still fails to build with a set neon flag.
Created attachment 402270 [details] build.log_neon-flag
(In reply to Mike Gilbert from comment #12) then the cmake files will need to be fixed to respect this setting. pretty sure that'll fix the neon build failure too.
My initial inclination would be to just remove that goofy cmake logic. However, it looks like upstream added this in response to some build failure on Debian, so they will need some convincing. https://github.com/FreeRDP/FreeRDP/issues/980
I opened an issue upstream to see how they want to handle it.
Created attachment 408082 [details] ebuild that consider the arch and the float option simply use of toolchain-funcs to detect arch and float type
(In reply to Mike Gilbert from comment #19) > I opened an issue upstream to see how they want to handle it. Looks like this was merged upstream - can we get a backport to the stable version in the Portage tree? :)
+ 06 Aug 2015; Mike Gilbert <floppym@gentoo.org> +files/freerdp-armfp.patch, + freerdp-1.2.1_pre20150326.ebuild: + Backport removal of ARM_FP_ABI option, bug 547246.
