Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 547114 - media-video/openshot: drop dependency on media-sound/sox
Summary: media-video/openshot: drop dependency on media-sound/sox
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2015-04-19 15:27 UTC by Sławomir Nizio
Modified: 2015-05-24 07:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sławomir Nizio 2015-04-19 15:27:25 UTC
From what I can see in openshot code, and according to an experiment, it gets sox effects throught mlt (either the Python API or the 'melt' executable), so the dependency should not be there.

Especially given that mlt has sox disabled!

mlt-0.9.0.ebuild:
113         --disable-sox"
114         #$(use_enable sox) FIXME

Also, the seemingly useless dependency is annoying because openshot has this:

media-sound/sox[encode,ffmpeg]

but the newest sox (sox-14.4.2.ebuild) has no 'ffmpeg' in IUSE (correctly, as that has been dropped by upstream, replaced by "ffmpeg/avconv via pipe").

What I propose to do:
- remove sox dependency from the openshot ebuild.

What can be done in the longer term:
- fix and enable mlt[sox] again.

I removed sox from my system and ran openshot and I saw no breakage.

By the way, the "mlt without sox" causes this:

Warning: effect not found in your version of Sox: sox:bass
Warning: effect not found in your version of Sox: sox:echo
Warning: effect not found in your version of Sox: sox:phaser
Warning: effect not found in your version of Sox: sox:treble


Reproducible: Always
Comment 1 Sławomir Nizio 2015-05-23 20:08:13 UTC
--- openshot-1.4.3.ebuild
+++ openshot-1.4.3.ebuild
@@ -28,7 +28,6 @@
 	>=media-libs/mlt-0.8.2[ffmpeg,frei0r,gtk,melt,python,sdl,xml]
 	ffmpeg? (
 		>=virtual/ffmpeg-0.6[encode,sdl,x264,mp3,theora]
-		media-sound/sox[encode,ffmpeg]
 	)
 	python? (
 		dev-python/httplib2[${PYTHON_USEDEP}]
Comment 2 Pacho Ramos gentoo-dev 2015-05-23 20:30:44 UTC
+  23 May 2015; Pacho Ramos <pacho@gentoo.org> openshot-1.4.3.ebuild:
+  Drop unneeded sox dep (#547114 by SN (Enlik), use new libav/ffmpeg handling
+

Sorry for the delay... have Sabayon people considered to try to directly become Gentoo devs to help us ;)

If you need a mentor or help, please don't hesitate to contact me :)

Best regards
Comment 3 Sławomir Nizio 2015-05-24 07:15:13 UTC
Thanks a lot Pacho! I did but time issues mainly… :)